Skip to content

Stabilize hint::spin_loop - #76097

Merged
bors merged 1 commit into
rust-lang:masterfrom
pickfire:stabilize-spin-loop
Nov 8, 2020
Merged

Stabilize hint::spin_loop#76097
bors merged 1 commit into
rust-lang:masterfrom
pickfire:stabilize-spin-loop

Conversation

@pickfire

@pickfire pickfire commented Aug 30, 2020 •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

View all comments

Partially fix #55002, deprecate in another release

r? @KodrAus

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 30, 2020
@pickfire
pickfire force-pushed the stabilize-spin-loop branch from dcb273e to 470f3f2 Compare August 30, 2020 02:41
nagisa
nagisa reviewed Aug 31, 2020
View reviewed changes
Comment thread library/core/src/sync/atomic.rs Resolved
@jyn514 jyn514 added the T-libs-api [DEPRECATED; DO NOT USE] label Aug 31, 2020
@jyn514

jyn514 commented Aug 31, 2020

Copy link
Copy Markdown
Member 
 error: the feature `renamed_spin_loop` has been stable since 1.47.0 and no longer requires an attribute to enable
   --> library/std/src/lib.rs:295:12
    |
295 | #![feature(renamed_spin_loop)]
    |            ^^^^^^^^^^^^^^^^^

Needs cfg_attr(bootstrap, feature(renamed_spin_loop))

@pickfire
pickfire force-pushed the stabilize-spin-loop branch from 470f3f2 to f3155d1 Compare August 31, 2020 15:03
@pickfire

pickfire commented Aug 31, 2020

Copy link
Copy Markdown
Contributor Author 
 error: the feature `renamed_spin_loop` has been stable since 1.47.0 and no longer requires an attribute to enable
   --> library/std/src/lib.rs:215:32
    |
215 | #![cfg_attr(bootstrap, feature(renamed_spin_loop))]
    |                                ^^^^^^^^^^^^^^^^^
    |
    = note: `-D stable-features` implied by `-D warnings`

error: aborting due to previous error

error: could not compile `std`.

Is it that it should be #![cfg_attr(not(bootstrap), feature(renamed_spin_loop))]?

KodrAus
KodrAus reviewed Sep 1, 2020
View reviewed changes

@KodrAus KodrAus left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it that it should be #![cfg_attr(not(bootstrap), feature(renamed_spin_loop))]?

I think we can actually just remove the renamed_spin_loop altogether, since that's what we're stabilizing. At least that seems to work for me locally 🙂

Comment thread library/core/src/hint.rs Resolved
@pickfire

pickfire commented Sep 5, 2020

Copy link
Copy Markdown
Contributor Author

I think we can actually just remove the renamed_spin_loop altogether, since that's what we're stabilizing. At least that seems to work for me locally slightly_smiling_face

Oh, I forgot that we could remove it.

@pickfire
pickfire force-pushed the stabilize-spin-loop branch from f3155d1 to f7ee5da Compare September 5, 2020 01:22
@KodrAus

KodrAus commented Sep 11, 2020

Copy link
Copy Markdown
Contributor

@bors try

@bors

bors commented Sep 11, 2020

Copy link
Copy Markdown
Collaborator

⌛ Trying commit f7ee5dad97d39755e8549c2eeb9121b0c2101477 with merge e76d95063a57c76c55da09725e42150bdfde978b...

@bors

bors commented Sep 11, 2020

Copy link
Copy Markdown
Collaborator

☀️ Try build successful - checks-actions, checks-azure
Build commit: e76d95063a57c76c55da09725e42150bdfde978b (e76d95063a57c76c55da09725e42150bdfde978b)

KodrAus
KodrAus reviewed Sep 11, 2020
View reviewed changes

@KodrAus KodrAus left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pickfire!

I've just left a few little suggestions, but I think this is looking good.

Comment thread library/core/src/hint.rs Resolved
Comment thread library/core/src/hint.rs Resolved
Comment thread library/core/src/hint.rs Resolved
Comment thread library/core/src/sync/atomic.rs Resolved
@jonas-schievink jonas-schievink added the relnotes Marks issues that should be documented in the release notes of the next release. label Sep 13, 2020
@KodrAus

KodrAus commented Sep 22, 2020

Copy link
Copy Markdown
Contributor

@bors try

@bors

bors commented Sep 22, 2020

Copy link
Copy Markdown
Collaborator

⌛ Trying commit 3d6b411233283c879dc1988ab031905c36e35cbb with merge b828e07c76cedb02561ae676718d3109080009c9...

@bors

bors commented Sep 22, 2020

Copy link
Copy Markdown
Collaborator

☀️ Try build successful - checks-actions, checks-azure
Build commit: b828e07c76cedb02561ae676718d3109080009c9 (b828e07c76cedb02561ae676718d3109080009c9)

@KodrAus

KodrAus commented Oct 5, 2020

Copy link
Copy Markdown
Contributor

Just circling back around to this now. It looks like we've got a happy build now! @pickfire would you like to update the example? After that I think this will be good to go, but we might want to bump the stabilization to 1.48.0.

@KodrAus

KodrAus commented Oct 5, 2020

Copy link
Copy Markdown
Contributor

@rustbot modify labels to +S-waiting-on-author, -S-waiting-on-review

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 5, 2020
@jyn514

jyn514 commented Oct 5, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

I think you mean 1.49 -- 1.48 will be promoted to beta on Tuesday.

@pickfire

pickfire commented Oct 5, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@KodrAus Example is updated. Thanks for the ping.

@pickfire
pickfire force-pushed the stabilize-spin-loop branch from 288033a to 6b4a184 Compare October 5, 2020 10:54
@pickfire

pickfire commented Oct 5, 2020

Copy link
Copy Markdown
Contributor Author

@KodrAus Sorry, I accidentally rebased the wrong commit and your commits were gone, I felt lazy to reflog it so I just added the co-authored to the commit message instead.

@pickfire
pickfire force-pushed the stabilize-spin-loop branch from 6b4a184 to badff9c Compare October 5, 2020 13:08
@jyn514 jyn514 closed this Nov 6, 2020
@bors

bors commented Nov 6, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit e8b5be5 has been approved by KodrAus

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 6, 2020
@jyn514 jyn514 reopened this Nov 6, 2020
m-ou-se added a commit to m-ou-se/rust that referenced this pull request Nov 7, 2020
@m-ou-se
Rollup merge of rust-lang#76097 - pickfire:stabilize-spin-loop, r=Kod…
8a27822 
…rAus

Stabilize hint::spin_loop

Partially fix rust-lang#55002, deprecate in another release

r? `@KodrAus`
@m-ou-se m-ou-se mentioned this pull request Nov 7, 2020
Closed
m-ou-se added a commit to m-ou-se/rust that referenced this pull request Nov 7, 2020
@m-ou-se
Rollup merge of rust-lang#76097 - pickfire:stabilize-spin-loop, r=Kod…
309522a 
…rAus

Stabilize hint::spin_loop

Partially fix rust-lang#55002, deprecate in another release

r? ``@KodrAus``
@m-ou-se m-ou-se mentioned this pull request Nov 7, 2020
Closed
m-ou-se added a commit to m-ou-se/rust that referenced this pull request Nov 7, 2020
@m-ou-se
Rollup merge of rust-lang#76097 - pickfire:stabilize-spin-loop, r=Kod…
ebe0a23 
…rAus

Stabilize hint::spin_loop

Partially fix rust-lang#55002, deprecate in another release

r? ```@KodrAus```
@m-ou-se m-ou-se mentioned this pull request Nov 7, 2020
Closed
m-ou-se added a commit to m-ou-se/rust that referenced this pull request Nov 7, 2020
@m-ou-se
Rollup merge of rust-lang#76097 - pickfire:stabilize-spin-loop, r=Kod…
c68f3b7 
…rAus

Stabilize hint::spin_loop

Partially fix rust-lang#55002, deprecate in another release

r? ````@KodrAus````
@m-ou-se m-ou-se mentioned this pull request Nov 7, 2020
Closed
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Nov 8, 2020
@Dylan-DPC
Rollup merge of rust-lang#76097 - pickfire:stabilize-spin-loop, r=Kod…
548e1b9 
…rAus

Stabilize hint::spin_loop

Partially fix rust-lang#55002, deprecate in another release

r? `````@KodrAus`````
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Nov 8, 2020
Closed
@m-ou-se m-ou-se mentioned this pull request Nov 8, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 8, 2020
@bors
Auto merge of rust-lang#78874 - m-ou-se:rollup-3jp1ijj, r=m-ou-se
b1277d0 
Rollup of 19 pull requests

Successful merges:

 - rust-lang#76097 (Stabilize hint::spin_loop)
 - rust-lang#76227 (Stabilize `Poll::is_ready` and `is_pending` as const)
 - rust-lang#78065 (make concurrency helper more pleasant to read)
 - rust-lang#78570 (Remove FIXME comment in print_type_sizes ui test suite)
 - rust-lang#78572 (Use SOCK_CLOEXEC and accept4() on more platforms.)
 - rust-lang#78658 (Add a tool to run `x.py` from any subdirectory)
 - rust-lang#78706 (Fix run-make tests running when LLVM is disabled)
 - rust-lang#78728 (Constantify `UnsafeCell::into_inner` and related)
 - rust-lang#78775 (Bump Rustfmt and RLS)
 - rust-lang#78788 (Correct unsigned equivalent of isize to be usize)
 - rust-lang#78811 (Make some std::io functions `const`)
 - rust-lang#78828 (use single char patterns for split() (clippy::single_char_pattern))
 - rust-lang#78841 (Small cleanup in `TypeFoldable` derive macro)
 - rust-lang#78842 (Honor the rustfmt setting in config.toml)
 - rust-lang#78843 (Less verbose debug logging from inlining integrator)
 - rust-lang#78852 (Convert a bunch of intra-doc links)
 - rust-lang#78860 (rustc_resolve: Use `#![feature(format_args_capture)]`)
 - rust-lang#78861 (typo and formatting)
 - rust-lang#78865 (Don't fire `CONST_ITEM_MUTATION` lint when borrowing a deref)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 1f034f7 into rust-lang:master Nov 8, 2020
@rustbot rustbot added this to the 1.49.0 milestone Nov 8, 2020
@pickfire
pickfire deleted the stabilize-spin-loop branch November 8, 2020 17:47
@pickfire pickfire mentioned this pull request Dec 9, 2020
Merged
@camelid camelid mentioned this pull request Jan 3, 2021
Closed
3 tasks done
@JEnoch JEnoch mentioned this pull request Nov 25, 2021
Closed
4 tasks done
@clarfonthey clarfonthey added the A-atomic Area: Atomics, barriers, and sync primitives label Nov 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nagisa nagisa nagisa left review comments
@m-ou-se m-ou-se m-ou-se left review comments
@KodrAus KodrAus KodrAus left review comments
+1 more reviewer
@jyn514 jyn514 jyn514 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@KodrAus KodrAus

Labels

A-atomic Area: Atomics, barriers, and sync primitives relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api [DEPRECATED; DO NOT USE]

Projects

None yet

Milestone

1.49.0

Development

Successfully merging this pull request may close these issues.

Tracking issue for hint::spin_loop (renamed sync::atomic::spin_loop_hint)