Rollup of 22 pull requests by JonathanBrouwer · Pull Request #165436 · rust-lang/rust

JonathanBrouwer · 2026-11-03T21:10:59Z

Successful merges:

Make inline attributes apply to the generated poll in async fn #149245 (Make inline attributes apply to the generated poll in async fn)
[perf] Reuse CanonicalVarKinds if no new variables were added #164304 ([perf] Reuse CanonicalVarKinds if no new variables were added)
Avoid building a region map when erasing bound regions #165109 (Avoid building a region map when erasing bound regions)
std: Use getexecpath() for current_exe() on OpenBSD #163393 (std: Use getexecpath() for current_exe() on OpenBSD)
Add a lint helper attribute namespace #163625 (Add a lint helper attribute namespace )
Add let_underscore_drop_guard lint. #164414 (Add let_underscore_drop_guard lint.)
Avoid unnecessary MIR traversals in CheckPackedRef lint #165342 (Avoid unnecessary MIR traversals in CheckPackedRef lint)
delegation: insert probing adjustments before args check adjustments #165351 (delegation: insert probing adjustments before args check adjustments)
Reenable some cg_gcc tests that were disabled #165358 (Reenable some cg_gcc tests that were disabled)
Make no_implicit_prelude not suppress tool attributes #165377 (Make no_implicit_prelude not suppress tool attributes)
Add codegen test for unused match arms removed after inlining #165397 (Add codegen test for unused match arms removed after inlining)
Rework parallel reproducibility tests #165398 (Rework parallel reproducibility tests)
Replace builtin # with k# #162232 (Replace builtin # with k#)
Avoid oscillating line wrapping due to symbol indices #162608 (Avoid oscillating line wrapping due to symbol indices)
make the safety documentation consistent in Ptr module #164241 (make the safety documentation consistent in Ptr module)
clarify when Vec::into_boxed_slice() is in-place #164258 (clarify when Vec::into_boxed_slice() is in-place)
Use MalformedLintAttributeInput in more places #165029 (Use MalformedLintAttributeInput in more places)
AIX: Implement TLS destructor guard in std and update dynamic-loading-cdylib test #165203 (AIX: Implement TLS destructor guard in std and update dynamic-loading-cdylib test)
Fix rigidity assertion ICE #165230 (Fix rigidity assertion ICE)
unstable-book: update default-visibility.md to link to tracking issue #165293 (unstable-book: update default-visibility.md to link to tracking issue)
Refactorings in preparation for the move trait #165374 (Refactorings in preparation for the move trait)
another Enzyme submodule update for nested autodiff #165421 (another Enzyme submodule update for nested autodiff)

OpenBSD added getexecpath(3) to libc, which returns an already-canonicalized executable path directly. Replace the sysctl(KERN_PROC_ARGV)-based implementation. This was the last user of div_exact in std, so drop the exact_div feature gate.

Instead of just showing the bare URL

…poll impl instead of the desugared creator function.

It is already rejected on such functions, and keeping it only produced a redundant 'incompatible with #[cold]' error.

instead tracking it through the whole traversal even if the lint is never fired

…being allowed Upstream no longer rejects the combination, so replace the UI test expecting that error with a codegen test checking that the body coroutine still inherits the target features.

We only need to traverse CFG for this lint, so we can iterate over basic blocks directly.

This lint is similar to the existing `let_underscore_lock` lint, but applies to `DropGuard` instead of `MutexGuard` and similar types.

…cdylib test: - Add `sys::thread_local::guard::aix` using `__pt_atexit_np` to run main thread TLS destructors on process exit on AIX. - Update `dynamic-loading-cdylib` to use member archive syntax (`RTLD_MEMBER`) for `dlopen` on AIX. - Replace the mode array in `dynamic-loading-cdylib` with a `COMMAND_ARGS` constant that selects `load_only` for musl and AIX because `dlclose` does not invoke TLS destructors on those platforms.

A comment against PR 151817 mentioned that the test file added in this PR kept causing "arbitrary" test file changes. This is because one line of the expanded output sits *just* at 78 columns, which is the pretty-printer's margin. Adding or removing a symbol shifts every index after it, and when one of those gains or loses a digit, the wrapping moves. We cannot use `normalize-stdout` as the layout is decided before normalization runs. We fix this by avoiding a strict golden comparison, and instead using a regex to directly test that the expected syntax contexts exist in the expanded output.

* Add regression test against rigidity assertion * Make non-rigid types equal to one another on error reporting * Bless errors after rigid treatment change * Remove previously useful crash test! * Add suggested comments from code review

…namespace

JonathanBrouwer · 2026-11-03T21:11:10Z

@bors r+ p=5 force

Trying commonly failed jobs
@bors try jobs=dist-various-1,test-various,test-x86_64-gnu-aux,test-x86_64-msvc-1,test-aarch64-apple-1,test-aarch64-apple-2,test-x86_64-mingw-1,test-i686-msvc,test-armhf-gnu,test-x86_64-gnu-llvm-22-3,test-aarch64-msvc-2

rust-bors · 2026-11-03T21:11:13Z

📌 Commit 99e05e9 has been approved by JonathanBrouwer

It is now in the queue for this repository.

Rollup of 22 pull requests try-job: dist-various-1 try-job: test-various try-job: test-x86_64-gnu-aux try-job: test-x86_64-msvc-1 try-job: test-aarch64-apple-1 try-job: test-aarch64-apple-2 try-job: test-x86_64-mingw-1 try-job: test-i686-msvc try-job: test-armhf-gnu try-job: test-x86_64-gnu-llvm-22-3 try-job: test-aarch64-msvc-2

rust-bors · 2026-11-04T00:42:17Z

☀️ Try build successful (CI)
Build commit: 9d0254b (9d0254bcdc59146397cb871b66142e244276391d)
Base parent: a94dce0 (a94dce0bbb3aab81bfdcc30e8a55d7dc95bc644d)

rust-bors · 2026-11-04T02:52:56Z

☀️ Test successful - CI
Approved by: JonathanBrouwer
Duration: 2h 58m 48s
Pushing 249cb16 to main...

rust-log-analyzer · 2026-11-04T03:05:00Z

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

   Compiling diff v0.1.13
   Compiling ureq v3.4.0
   Compiling citool v0.1.0 (/home/runner/work/rust/rust/src/ci/citool)
    Finished `release` profile [optimized] target(s) in 53.33s
     Running `target/release/citool post-merge-report 708c94ef093ecc42fb8851e17d8383d999727abc 249cb163c0d076be9e0d1a838d2156dfd490ecba`
Downloading metrics of job test-aarch64-gnu
Downloading metrics of job test-aarch64-gnu-debug
Downloading metrics of job test-arm-android
Downloading metrics of job test-armhf-gnu
Downloading metrics of job dist-aarch64-linux

rust-bors · 2026-11-04T04:05:31Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#149245	Make inline attributes apply to the generated `poll` in asy…	`8fc1145dbcf70365873d947ad84b18411653e94a` (link)
#164304	[perf] Reuse CanonicalVarKinds if no new variables were add…	`666da1f17e666a018217a8ee5d0a5232663ae312` (link)
#165109	Avoid building a region map when erasing bound regions	`747974ba22e48b6df3d553c81a4fb971b51adb70` (link)
#163393	std: Use getexecpath() for current_exe() on OpenBSD	`66edca2371cb9716e52c8106d88f012a658bf100` (link)
#163625	Add a lint helper attribute namespace	`aa97bd8f205dae01018b6c057485fa17d93e9e7f` (link)
#164414	Add `let_underscore_drop_guard` lint.	`15fc2113295a20f459d51880ea27a634a1bbb043` (link)
#165342	Avoid unnecessary MIR traversals in CheckPackedRef lint	`0cf9b552a78bb9a9c36b1d480cf0290ffb687f70` (link)
#165351	delegation: insert probing adjustments before args check ad…	`a9bb8aaeae1e9629a9c8239cac53ffc2a4671837` (link)
#165358	Reenable some cg_gcc tests that were disabled	`b981975da3e2fb2a4773016c555f6a438b40c96c` (link)
#165377	Make `no_implicit_prelude` not suppress tool attributes	`f890962cd1032382db47abbd44fefd69c1f50d3f` (link)
#165397	Add codegen test for unused match arms removed after inlini…	`e50e545534c7a53a64be280faab10b807c87f147` (link)
#165398	Rework parallel reproducibility tests	`a0c659af17a177880dc189d88d8d7f1059a48f17` (link)
#162232	Replace `builtin #` with `k#`	`fe189c5f177e8ea89d0701aeb2d597a4603ced69` (link)
#162608	Avoid oscillating line wrapping due to symbol indices	`6c61b08bcc16b2d418bc7acaf1cfb9b3d1c8c2a7` (link)
#164241	make the safety documentation consistent in Ptr module	`77106feddd738dd9c5247423aef3656faa21037a` (link)
#164258	clarify when `Vec::into_boxed_slice()` is in-place	`e2eca809204cae2c3dc2389f5452383755ee4e60` (link)
#165029	Use `MalformedLintAttributeInput` in more places	`454fdb1d2db7522f195823deafd4b1bdc398328e` (link)
#165203	AIX: Implement TLS destructor guard in std and update dynam…	`f0c81e2aaf07debd3a166c0f231f449b349c2506` (link)
#165230	Fix rigidity assertion ICE	`ea6e3d265870e2ea2ae1429b30ff9e82a69f45a0` (link)
#165293	unstable-book: update default-visibility.md to link to trac…	`03a2530e428c20acd0d7384b61571309ccd50d53` (link)
#165374	Refactorings in preparation for the move trait	`350a76f24d56e5d75e2b38e96f6cf5f8ea87fbd8` (link)
#165421	another Enzyme submodule update for nested autodiff	`9c3d6fb7dfedb63ad97c5d4f5589dc43add06fce` (link)

parent commit: 708c94ef09

In the case of a perf regression, run the following command with the SHAs of each PR you suspect might be the cause: @rust-timer triage $SHA $SHA $SHA..., or run @rust-timer triage all to benchmark all rollup members.

rust-timer · 2026-11-04T04:19:40Z

Finished benchmarking commit (249cb16): comparison URL.

Overall result: ❌✅ regressions and improvements - please read:

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

If the regression was expected or you think it can be justified,
please write a comment with sufficient written justification, and add
@rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
If you think that you know of a way to resolve the regression, try to create
a new PR with a fix for the regression.
If you do not understand the regression or you think that it is just noise,
you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Conversation

JonathanBrouwer commented Nov 3, 2026

Uh oh!

JonathanBrouwer commented Nov 3, 2026

Uh oh!

rust-bors Bot commented Nov 3, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors Bot commented Nov 4, 2026

Uh oh!

rust-bors Bot commented Nov 4, 2026

Uh oh!

Uh oh!

rust-log-analyzer commented Nov 4, 2026

Uh oh!

rust-bors Bot commented Nov 4, 2026

Uh oh!

rust-timer commented Nov 4, 2026

Overall result: ❌✅ regressions and improvements - please read:

Uh oh!

panstromek commented Nov 4, 2026

Uh oh!

rust-timer commented Nov 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

#149245 8fc1145 Make inline attributes apply to the generated poll in async fn

#164304 666da1f [perf] Reuse CanonicalVarKinds if no new variables were added

#165109 747974b Avoid building a region map when erasing bound regions

#163393 66edca2 std: Use getexecpath() for current_exe() on OpenBSD

#163625 aa97bd8 Add a lint helper attribute namespace

#164414 15fc211 Add let_underscore_drop_guard lint.

#165342 0cf9b55 Avoid unnecessary MIR traversals in CheckPackedRef lint

#165351 a9bb8aa delegation: insert probing adjustments before args check adjustments

#165358 b981975 Reenable some cg_gcc tests that were disabled

#165377 f890962 Make no_implicit_prelude not suppress tool attributes

#165397 e50e545 Add codegen test for unused match arms removed after inlining

#165398 a0c659a Rework parallel reproducibility tests

#162232 fe189c5 Replace builtin # with k#

#162608 6c61b08 Avoid oscillating line wrapping due to symbol indices

#164241 77106fe make the safety documentation consistent in Ptr module

#164258 e2eca80 clarify when Vec::into_boxed_slice() is in-place

#165029 454fdb1 Use MalformedLintAttributeInput in more places

#165203 f0c81e2 AIX: Implement TLS destructor guard in std and update dynamic-loading-cdylib test

#165230 ea6e3d2 Fix rigidity assertion ICE

#165293 03a2530 unstable-book: update default-visibility.md to link to tracking issue

#165374 350a76f Refactorings in preparation for the move trait

#165421 9c3d6fb another Enzyme submodule update for nested autodiff

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

rust-timer commented Nov 4, 2026 •

edited

Loading

#149245 `8fc1145` Make inline attributes apply to the generated `poll` in async fn

#164304 `666da1f` [perf] Reuse CanonicalVarKinds if no new variables were added

#165109 `747974b` Avoid building a region map when erasing bound regions

#163393 `66edca2` std: Use getexecpath() for current_exe() on OpenBSD

#163625 `aa97bd8` Add a lint helper attribute namespace

#164414 `15fc211` Add `let_underscore_drop_guard` lint.

#165342 `0cf9b55` Avoid unnecessary MIR traversals in CheckPackedRef lint

#165351 `a9bb8aa` delegation: insert probing adjustments before args check adjustments

#165358 `b981975` Reenable some cg_gcc tests that were disabled

#165377 `f890962` Make `no_implicit_prelude` not suppress tool attributes

#165397 `e50e545` Add codegen test for unused match arms removed after inlining

#165398 `a0c659a` Rework parallel reproducibility tests

#162232 `fe189c5` Replace `builtin #` with `k#`

#162608 `6c61b08` Avoid oscillating line wrapping due to symbol indices

#164241 `77106fe` make the safety documentation consistent in Ptr module

#164258 `e2eca80` clarify when `Vec::into_boxed_slice()` is in-place

#165029 `454fdb1` Use `MalformedLintAttributeInput` in more places

#165203 `f0c81e2` AIX: Implement TLS destructor guard in std and update dynamic-loading-cdylib test

#165230 `ea6e3d2` Fix rigidity assertion ICE

#165293 `03a2530` unstable-book: update default-visibility.md to link to tracking issue

#165374 `350a76f` Refactorings in preparation for the move trait

#165421 `9c3d6fb` another Enzyme submodule update for nested autodiff