Repository navigation
Rollup of 7 pull requests - #165432
Merged
Merged
Rollup of 7 pull requests#165432
Conversation
Otherwise the llvm::Error object's destrcutor asserts.
Previusly we had a disagreement between hir_typeck (assuming that anything following the diverging constant is unreachable) and mir_build (assuming we don't need to evaluate constants in `[...; 0]`). This (temporarily) fixes this by making hir_typeck aware that such constants should not affect divergence / reachibility analysis
…ted_zero_times, r=oli-obk fix unsoundness when compiling `[diverging_const; 0]` As I described in rust-lang#165323 (comment), currently `[diverging_const; 0]` leads to usoundness because hir type check and mir building disagree on whatever `diverging_const` is evaluated or not. hir type check assumes that it does (and marks anything after it as unreachable) while mir building sees that the constant is repeated 0 times and decides to skip evaluating the constant, resulting in unsoundness. This PR fixes this by doing the same kind of special case in hir type check. Fixes (but does not close as this is a temporary workaround) rust-lang#165323
…=GuillaumeGomez [perf] rustdoc: Avoid re-HIR-ty-lowering tys & const args where possible <sub>(No LLM was or will be used by me during the entire creation process of this PR)</sub>
…rtdev Don't use `llvm_type` as the type of `static`s. This PR replaces the two uses of `llvm_type` as the type of `static`s - only the size of the static matters, so `cx.type_array(cx.type_i8(), layout.size)` is sufficient. As `static`s have to be redefined if the initialiser type is not the same as the existing type. using an LLVM `i8` array here is more optimal as it means the static type already matches the initializer in cases where the initializer is just plain bytes. r? @folkertdev
…ngjubilee Remove `AbiAlign` The first commit removes the final use of `AbiAlign` (as a field of `LayoutData`), and the second commit removes `AbiAlign` itself. r? @workingjubilee
…lf, r=Urgau rustdoc: Fix invalid clean of paths when they end with `self` Fixes rust-lang#165317. Fixes rust-lang#164427. We weren't checking in `clean_path` whether a path was ending with `self` or not. r? @Urgau
…rtdev Add codegen test for step_by(1) loop vectorization Fixes rust-lang#57517 This was fixed by the LLVM 16 update in rust-lang#109474
LLVMRustWriteOutputFile: Check the result of runCodeGenPipeline Otherwise the llvm::Error object's destructor asserts. This is a follow-up to rust-lang#163672
rustbot
added
A-LLVM
Member
Author
Contributor
rust-bors
Bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Nov 3, 2026
Rollup of 7 pull requests try-job: dist-various-1 try-job: test-various try-job: test-x86_64-gnu-aux try-job: test-x86_64-msvc-1 try-job: test-aarch64-apple-1 try-job: test-aarch64-apple-2 try-job: test-x86_64-mingw-1 try-job: test-i686-msvc try-job: test-armhf-gnu try-job: test-x86_64-gnu-llvm-22-3 try-job: test-aarch64-msvc-2
This comment has been minimized.
This comment has been minimized.
Contributor
rust-bors
Bot
added
merged-by-bors
Contributor
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing a94dce0 (parent) -> 708c94e (this PR) Test differencesShow 38 test diffsStage 1
Stage 2
Additionally, 21 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 708c94ef093ecc42fb8851e17d8383d999727abc --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Collaborator
|
Finished benchmarking commit (708c94e): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)This perf run didn't have relevant results for this metric. CyclesThis perf run didn't have relevant results for this metric. Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: 484.08s -> 483.649s (-0.09%) |
Contributor
|
📌 Perf builds for each rolled up PR:
parent commit: a94dce0bbb In the case of a perf regression, run the following command with the SHAs of each PR you suspect might be the cause: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
[diverging_const; 0]#165416 (fix unsoundness when compiling[diverging_const; 0])llvm_typeas the type ofstatics. #165371 (Don't usellvm_typeas the type ofstatics.)AbiAlign#165354 (RemoveAbiAlign)self#165357 (rustdoc: Fix invalid clean of paths when they end withself)r? @ghost
Create a similar rollup