Skip to content

Add assembly test for masked index without redundant shifts - #165288

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
zakrad:asm-test-56057
Nov 2, 2026
Merged

Add assembly test for masked index without redundant shifts#165288
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
zakrad:asm-test-56057

Conversation

@zakrad

@zakrad zakrad commented Nov 1, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

Fixes #56057

This was fixed by the LLVM 18 update in #120055

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 1, 2026
@rustbot

rustbot commented Nov 1, 2026

Copy link
Copy Markdown
Collaborator

r? @khyperia

rustbot has assigned @khyperia.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 77 candidates
  • Random selection from 22 candidates

@khyperia

khyperia commented Nov 2, 2026

Copy link
Copy Markdown
Member

@bors r+ rollup

@rust-bors

rust-bors Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 2be9314 has been approved by khyperia

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 2, 2026
@JonathanBrouwer JonathanBrouwer mentioned this pull request Nov 2, 2026
Merged
rust-bors Bot pushed a commit that referenced this pull request Nov 2, 2026
@bors
Auto merge of #165361 - JonathanBrouwer:rollup-cJpJ1RA, r=JonathanBro…
1c3a650 
…uwer

Rollup of 6 pull requests

Successful merges:

 - #163764 (Tweak suggestion of "unreachable due to never pattern")
 - #164771 (std: fix platform checks for hermit)
 - #165070 (create mir for direct-rhs consts)
 - #165121 (test DSL evaluate sequentially)
 - #165288 (Add assembly test for masked index without redundant shifts)
 - #165307 (test(lexer): Add test that ZWJ/ZWNJ are accepted in identifiers)
@rust-bors
rust-bors Bot merged commit e29e16f into rust-lang:main Nov 2, 2026
14 checks passed
@rustbot rustbot added this to the 1.101.0 milestone Nov 2, 2026
rust-bors Bot pushed a commit that referenced this pull request Nov 2, 2026
@bors
Unrolled build for #165288 in rollup 165361
452d7da 
Rollup merge of #165288 - zakrad:asm-test-56057, r=khyperia

Add assembly test for masked index without redundant shifts

Fixes #56057

This was fixed by the LLVM 18 update in #120055
@zakrad
zakrad deleted the asm-test-56057 branch November 2, 2026 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@khyperia khyperia

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.101.0

Development

Successfully merging this pull request may close these issues.

Missing optimization with signed pointer offset

3 participants

@zakrad @rustbot @khyperia