Repository navigation
Build TPDE with local Clang when available - #165275
Open
TechnoPorg wants to merge 2 commits into
Open
TechnoPorg wants to merge 2 commits into
TechnoPorg wants to merge 2 commits into
Conversation
Collaborator
|
This PR changes how LLVM is built. Consider updating src/bootstrap/download-ci-llvm-stamp. |
rustbot
added
S-waiting-on-review
aengelke
reviewed
Nov 2, 2026
TechnoPorg
force-pushed
the
push-wrpxssqqoxqw
branch
from
November 2, 2026 23:51
1b3666c to
59241dc
Compare
ZuseZ4
reviewed
Nov 3, 2026
Member
|
I don't think we need to add a warning this time. Clang isn't free to build, and there are legitimate setups where people have a suitable clang available externally and set the paths correctly. If someone's already using a new bootstrap feature like tpde, they'll hopefully read the docs. |
TechnoPorg
force-pushed
the
push-wrpxssqqoxqw
branch
from
November 3, 2026 12:55
59241dc to
2485e0e
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As noted in #164108 (review), TPDE requires a clang with a major version <= the LLVM major version, and performance tends to be better when built with clang. This PR makes TPDE compilation and encodegen use the locally built clang if it's available.
I haven't added any sort of warning if
llvm.clangis not set as TPDE will throw its own error if the major version is too high. Maybe it's worth doing so, though?This also includes the TPDE compilation fix commit from #164108. We will see which ones makes it in first.
r? @ZuseZ4