Repository navigation
Fix unused attribute duplication for lint attributes - #165249
Open
JonathanBrouwer wants to merge 2 commits into
Open
JonathanBrouwer wants to merge 2 commits into
JonathanBrouwer wants to merge 2 commits into
Conversation
Collaborator
|
Some changes occurred in compiler/rustc_attr_parsing |
rustbot
added
A-attributes
Member
|
I think the motivation for the assertion is somewhat weak. Did you encounter this situation in this PR? |
Member
Author
|
Yes, specifically lint attributes parsed during early linting cannot themselves emit lints, without the This specific problem should be fixed after #164918, but I thought the assertion could be useful to prevent similar problems in the future. I also encountered this problem when trying to emulate the old behaviour here: |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @mejrs