Repository navigation
Move a bunch of methods out of AttributeExt - #165201
Open
JonathanBrouwer wants to merge 12 commits into
Open
JonathanBrouwer wants to merge 12 commits into
JonathanBrouwer wants to merge 12 commits into
Conversation
Collaborator
|
cc @rust-lang/clippy Some changes occurred in compiler/rustc_attr_ir |
rustbot
added
A-attributes
This comment has been minimized.
This comment has been minimized.
mejrs
reviewed
Oct 31, 2026
| } | ||
|
|
||
| pub fn name(&self) -> Option<Symbol> { | ||
| pub fn name(&self) -> Symbol { |
Member
There was a problem hiding this comment.
We're planning to add a tool attribute to Generated, this signature is incompatible with that.
Member
Author
There was a problem hiding this comment.
Fixed by removing this function and replacing it with a function fn path(&self) -> &'static [Symbol]
JonathanBrouwer
force-pushed
the
attr-ext
branch
2 times, most recently
from
October 31, 2026 10:33
e878f19 to
ce51c80
Compare
This comment has been minimized.
This comment has been minimized.
JonathanBrouwer
force-pushed
the
attr-ext
branch
from
October 31, 2026 19:36
ce51c80 to
7f1953f
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
JonathanBrouwer
force-pushed
the
attr-ext
branch
from
November 1, 2026 13:09
7f1953f to
427fe59
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
approved these changes
Nov 4, 2026
Member
|
Thanks! @bors r+ |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Nov 4, 2026
…umeGomez Move a bunch of methods out of `AttributeExt` Moves a bunch of methods from `AttributeExt` to `ast::Attribute` Can be reviewed commit by commit, every commit passes tests. r? @GuillaumeGomez
rust-bors Bot
pushed a commit
that referenced
this pull request
Nov 4, 2026
…uwer Rollup of 17 pull requests Successful merges: - #164752 (Apply the Cortex-A53 843419 CC mitigation to aarch64 targets ) - #165011 (std: Clean up and improve errors for `is_*_feature_detected` macros) - #165376 (Add `Forget` trait feature gate) - #164482 (Remove the label starting with 0 in the test binary_asm_labels_allowed.rs) - #165201 (Move a bunch of methods out of `AttributeExt`) - #165268 (Fix constant-pattern equality suggestion spans in macros) - #165318 (Fix explicit destructor-call suggestion spans in macros) - #164440 ([Outreachy] alloc: Add test coverage for try_clone_from_ref_in (Box, Arc, Rc)) - #165001 (Document allocator swap in BinaryHeap::append) - #165257 (Revert FCW on lint attributes on macro calls) - #165330 (Impl read_le/read_be for f16 and f128) - #165364 (Update books) - #165414 (Remove unusued query key impl) - #165424 (Update amdgpu datalayout for LLVM 24) - #165440 (docker: bump node to v24.22.2 in shared script) - #165443 (Add `Discriminant::ord`) - #165445 (Add an unstable option to increase the chain depth of the next solver overflow FCW)
rust-bors Bot
pushed a commit
that referenced
this pull request
Nov 4, 2026
…uwer Rollup of 17 pull requests Successful merges: - #164752 (Apply the Cortex-A53 843419 CC mitigation to aarch64 targets ) - #165011 (std: Clean up and improve errors for `is_*_feature_detected` macros) - #165376 (Add `Forget` trait feature gate) - #164482 (Remove the label starting with 0 in the test binary_asm_labels_allowed.rs) - #165201 (Move a bunch of methods out of `AttributeExt`) - #165268 (Fix constant-pattern equality suggestion spans in macros) - #165318 (Fix explicit destructor-call suggestion spans in macros) - #164440 ([Outreachy] alloc: Add test coverage for try_clone_from_ref_in (Box, Arc, Rc)) - #165001 (Document allocator swap in BinaryHeap::append) - #165257 (Revert FCW on lint attributes on macro calls) - #165330 (Impl read_le/read_be for f16 and f128) - #165364 (Update books) - #165414 (Remove unusued query key impl) - #165424 (Update amdgpu datalayout for LLVM 24) - #165440 (docker: bump node to v24.22.2 in shared script) - #165443 (Add `Discriminant::ord`) - #165445 (Add an unstable option to increase the chain depth of the next solver overflow FCW)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves a bunch of methods from
AttributeExttoast::AttributeCan be reviewed commit by commit, every commit passes tests.
r? @GuillaumeGomez