Repository navigation
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
rustbot
added
A-testsuite
marcpems
changed the title
Collaborator
|
|
marcpems
marked this pull request as ready for review
October 29, 2026 16:28
Collaborator
|
Some changes occurred in src/tools/opt-dist cc @Kobzol |
rustbot
added
S-waiting-on-review
Contributor
|
☔ The latest upstream changes (presumably #165582) made this pull request unmergeable. Please resolve the merge conflicts by rebasing. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
View all comments
This change works around an issue in sccache when handling PGO file names for msvc parameters when calling clang-cl.
The original issue is that any changes to the PGO profile data files will not cause a sccache miss for the relevant binaries when rebuilding for optimization, and instead will pull the cached obj files, skipping any prof data changes.
This works by adding the profdata file contents directly to the hash for relevant targets using a SCCACHE_EXTRAFILES additional setting.
When the sccache issue is resolved and in use with Rust, this change can be safely reverted.
mozilla/sccache#2962
LLM disclosure:
Astra LLM was used in diagnosing the issue, running validation passes and correctness tests.
r? kobzol