[mejrs]

View all comments

fixes #161984

It's a breaking change, technically. I didn't find it in the crater rollup, but will rerun just in case.

[rustbot]

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

[rustbot]

r? @fee1-dead

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

• Owners of files modified in this PR: compiler
• compiler expanded to 77 candidates
• Random selection from 17 candidates

[mejrs]

@craterbot check crates=https://crater-reports.s3.amazonaws.com/pr-164148-crater-rollup/retry-regressed-list.txt p=1

[craterbot]

🚨 Error: missing start toolchain

🆘 If you have any trouble with Crater please ask in t-infra on Zulip
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

[mejrs]

@bors try

[JonathanBrouwer]

r=me with lang approval

View changes since this review

[mejrs]

Is the doc attribute t-lang or t-rustdoc territory?

[JonathanBrouwer]

Oh right, yeah I think T-rustdoc should be fine? Not sure tbh probably better to ask them

[rust-bors]

☀️ Try build successful (CI)
Build commit: 04e9298 (04e9298c771dcc8a88d17c0257382c1e4ae3da97)
Base parent: b26b4e7 (b26b4e75de6aac63fc6beeecebad5b3a5f84d2a4)

[mejrs]

@craterbot check crates=https://crater-reports.s3.amazonaws.com/pr-164148-crater-rollup/retry-regressed-list.txt p=1

[craterbot]

👌 Experiment pr-164582 created and queued.
🤖 Automatically detected try build 04e9298
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

[craterbot]

🚧 Experiment pr-164582 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

[craterbot]

🎉 Experiment pr-164582 is completed!
📊 0 regressed and 0 fixed (28882 total)
📊 1098 spurious results on the retry-regressed-list.txt, consider a retry¹ if this is a significant amount.
📰 Open the summary report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

Footnotes

1. re-run the experiment with crates=https://crater-reports.s3.amazonaws.com/pr-164582/retry-regressed-list.txt ↩

[JonathanBrouwer]

@rust-lang/rustdoc What is the proper procedure to nominate a PR to you? Is applying S-waiting-on-t-rustdoc sufficient?

[GuillaumeGomez]

Generally, pinging someone from the team so someone puts it in the agenda. Might be worth mentioning it in our guide.

[GuillaumeGomez]

Although in this case, I think we can just start an FCP.

@rfcbot fcp merge rustdoc-internals

[rust-rfcbot]

@GuillaumeGomez has proposed to merge this. The next step is review by the rest of the tagged team members:

• @GuillaumeGomez
• @Manishearth
• @Urgau
• @camelid
• @fmease
• @lolbinarycat
• @notriddle
• @yotamofek

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

[lolbinarycat]

I think this is good, tho my instinct is that small breakages like this that don't break anything in practices should maybe still get a relnotes entry?

[rustbot]

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

[notriddle]

FCP waiting on @Manishearth @fmease @yotamofek

[fmease]

I think this is good, tho my instinct is that small breakages like this that don't break anything in practices should maybe still get a relnotes entry?

This happens automatically: rustbot is gonna create an issue tagged relnotes-tracking-issue Marks issues tracking what text to put in release notes. once an FCP-merge finishes which is then going to be picked up by T-release members.

[rust-rfcbot]

🔔 This is now entering its final comment period, as per the review above. 🔔

[theemathas]

@craterbot check doesn't run rustdoc. Is just running cargo check sufficient to detect breakage?

[JonathanBrouwer]

Yes. The doc attribute parser also runs under normal rustc.
For example, this program fails cargo check on nightly

#![doc(rust_logo)] //~ ERROR this subset of the `doc` attribute is meant for internal use only
fn main() { }