Skip to content

Parser: Clean up parse_expr_dot_or_call_with & simplify parse_expr_prefix - #164537

Open
fmease wants to merge 2 commits into
rust-lang:mainfrom
fmease:parser-cleanup-prefix-op
Open

fmease wants to merge 2 commits into
rust-lang:mainfrom
fmease:parser-cleanup-prefix-op

Conversation

@fmease

@fmease fmease commented Oct 18, 2026 •

Copy link
Copy Markdown
Member

(No LLM was or will be used by me during the entire creation process of this PR)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 18, 2026
@rustbot

rustbot commented Oct 18, 2026

Copy link
Copy Markdown
Collaborator

r? @camelid

rustbot has assigned @camelid.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler, parser
  • compiler, parser expanded to 77 candidates
  • Random selection from 20 candidates

@fmease fmease added the C-cleanup Category: PRs that clean code up or issues documenting cleanup. label Oct 18, 2026
@fmease
fmease force-pushed the parser-cleanup-prefix-op branch from 1d66175 to b255bbd Compare October 18, 2026 21:28
@fmease

fmease commented Oct 18, 2026

Copy link
Copy Markdown
Member Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 18, 2026
@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Oct 18, 2026
Parser: Clean up `parse_expr_dot_or_call_with` & simplify `parse_expr_prefix`
@rust-bors

rust-bors Bot commented Oct 18, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: bf712a5 (bf712a5851cabfcef6f5397f6ebe1eef0db3297b)
Base parent: 15c1044 (15c10447a46529b68e38c7f138aeb95240e4d7d6)

@rust-timer

This comment has been minimized.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (bf712a5): comparison URL.

Overall result: ❌ regressions - no action needed

Benchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up.

@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.3% [0.3%, 0.3%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (secondary 3.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
3.7% [3.5%, 3.8%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Cycles

Results (secondary 0.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.8% [2.8%, 2.8%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.3% [-2.3%, -2.3%] 1
All ❌✅ (primary) - - 0

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 490.17s -> 496.821s (1.36%)
Artifact size: 408.94 MiB -> 409.03 MiB (0.02%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 18, 2026
@fmease

fmease commented Oct 23, 2026

Copy link
Copy Markdown
Member Author

(most likely spurious)

(I originally issued the perf run since I converted macro calls into function pointer calls)

@rust-bors

This comment has been minimized.

@fmease
fmease force-pushed the parser-cleanup-prefix-op branch from b255bbd to e3bd229 Compare November 3, 2026 13:25
@rustbot

rustbot commented Nov 3, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Don't artificially suppress the `.` & `?` expectation after `return`
that doesn't make any sense. `return.field` & `return?` are perfectly
legal. Moreover, this rather simplistic check didn't even account for any
of `return`'s "siblings" (`break`, `continue`, `yield`, `become`,
`do yeet`).

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-cleanup Category: PRs that clean code up or issues documenting cleanup. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants