[crater] check fallout of reserving unknown doc attributes by mejrs · Pull Request #163699 · rust-lang/rust

mejrs · 2026-10-03T13:35:17Z

currently, it is always a (theoretical) breaking change to feature gate something like #[doc(new_doc_attr)], because that would previously compile with a "unused" warnings.

I'm curious what the fallout of this is and I also have some ideas for new doc attributes, for which I'd like to know whether the name is available.

mejrs · 2026-10-03T14:20:20Z

@bors try

[crater] check fallout of reserving unknown doc attributes

rust-bors · 2026-10-03T15:24:48Z

☀️ Try build successful (CI)
Build commit: fb2ae76 (fb2ae767043b99e76f81c9c92fd25cd4100d980d)
Base parent: d6b6dc7 (d6b6dc7982ef5d9117d96d018dfd83098d0471a1)

mejrs · 2026-10-03T15:28:21Z

@craterbot check

craterbot · 2026-10-03T15:28:45Z

👌 Experiment pr-163699 created and queued.
🤖 Automatically detected try build fb2ae76
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

notriddle · 2026-10-03T16:50:52Z

For the record, we tried making invalid doc attributes a hard error, but too much existing code was broken. That's why we made it a lint in the first place. #151865

mejrs · 2026-10-03T18:23:16Z

Ah, that regression is orthogonal to this, though.

Let's also crater a fix for #161984 while I'm at it.

@craterbot cancel
@bors try

[crater] check fallout of reserving unknown doc attributes

craterbot · 2026-10-03T18:23:34Z

🗑️ Experiment pr-163699 deleted!

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

rust-bors · 2026-10-03T19:22:54Z

☀️ Try build successful (CI)
Build commit: f3df2fe (f3df2feb79b2422c028f78855ec6ffe2e212d7cc)
Base parent: db8f076 (db8f076d2619ce2585b0380dda06e8da25a40da4)

mejrs · 2026-10-03T19:39:18Z

@craterbot check

craterbot · 2026-10-03T19:39:41Z

👌 Experiment pr-163699 created and queued.
🤖 Automatically detected try build f3df2fe
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

rust-bors · 2026-10-06T01:07:52Z

☔ The latest upstream changes (presumably #163842) made this pull request unmergeable. Please resolve the merge conflicts by rebasing.

theemathas · 2026-10-11T12:16:45Z

Crater rollup in #164148

@craterbot abort

craterbot · 2026-10-11T12:17:16Z

🗑️ Experiment pr-163699 deleted!

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

theemathas · 2026-10-18T12:46:14Z

@craterbot check crates=https://crater-reports.s3.amazonaws.com/pr-164148-crater-rollup/retry-regressed-list.txt p=1

craterbot · 2026-10-18T12:46:18Z

👌 Experiment pr-163699 created and queued.
🤖 Automatically detected try build f3df2fe
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2026-10-19T08:03:59Z

🚧 Experiment pr-163699 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2026-10-19T11:36:25Z

🎉 Experiment pr-163699 is completed!
📊 971 regressed and 0 fixed (28882 total)
📊 1118 spurious results on the retry-regressed-list.txt, consider a retry¹ if this is a significant amount.
📰 Open the summary report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

re-run the experiment with crates=https://crater-reports.s3.amazonaws.com/pr-163699/retry-regressed-list.txt ↩

notriddle · 2026-10-21T04:23:05Z

I looked at the results, and found:

crate	error
KeystoneHQ/rust-numext	reserved `doc` attribute `hide`
SergioBenitez/Pear/4b68055	reserved `doc` attribute `hiden`
async-coap-uri-0.1.0	reserved `doc` attribute `unstable`
bugadani/embedded-layout	reserved `doc` attribute `hide`
edi-0.2.0	reserved `doc` attribute `skip`
ethox-0.0.2	reserved `doc` attribute `shown`
evegfx-0.6.0	reserved `doc` attribute `hide`
foldu/cfgen/d730b5dc14d289b855615d382c04a06766337795	reserved `doc` attribute `hide`
futures-io-0.2.0/0.2.1/-preview-0.2.2	reserved `doc` attribute `html_rnoot_url`
futures-io-0.2.1	reserved `doc` attribute `html_rnoot_url`
gtmpl-0.5.7/0.6.0	reserved `doc` attribute `inlne`
harfbuzz_rs-1.0.0/1.0.1/1.1.1/1.2.0	reserved `doc` attribute `hide`
lyon_algorithms-0.11.2/0.13.1/0.13.4/0.14.0/0.15.0/0.15.1/0.16.0	reserved `doc` attribute `Hidden`
monadicus/snarkVM	reserved `doc` attribute `hide`
nical/lyon	reserved `doc` attribute `Hidden`
numext-fixed-uint-core-0.1.6	reserved `doc` attribute `hide`
oracle-0.3.3	reserved `doc` attribute `hide`
otel-arrow-dfe-pdata-0.61.0	reserved `doc` attribute `otlp_qualified_name`
pea2pea-0.16.4	reserved `doc` attribute `hide`
pear-0.2.0	reserved `doc` attribute `hiden`
scipr-lab/zexe	reserved `doc` attribute `hideen`
smoltcp-0.4.0/0.6.0/0.7.0	reserved `doc` attribute `shown`
swc_ecma_transforms_base-0.2.9	reserved `doc` attribute `hideen`
tinytemplate-1.0.1/1.0.2/1.0.3/1.0.4	reserved `doc` attribute `Hidden`
topo-0.9.4	reserved `doc` attribute `hiddent`
vial-0.1.0/0.1.9	reserved `doc` attribute `Hidden`
wzhd/rstcp	reserved `doc` attribute `shown`
zeroable-0.2.0	reserved `doc` attribute `noinline`

Sorted in order of most common keyword:

count	keyword
9	hide
4	Hidden
3	shown
2	html_rnoot_url
2	hiden
2	hideen
1	unstable
1	skip
1	otlp_qualified_name
1	noinline
1	inlne
1	hiddent

mejrs · 2026-10-26T22:13:14Z

I'm leaning towards just linting on all of those that are clearly typos, but implementing an error for everything else:

unstable can reasonably gain actual meaning at some point
otlp_qualified_name is blatant misuse of the doc attribute, (to convey information from a macro to a parser?) they could use a doc comment or a custom tool attribute instead
and everything else

reserve unknown doc attributes

e54078b

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Oct 3, 2026

Auto merge of #163699 - mejrs:reserve_doc_attrs, r=<try>

fb2ae76

[crater] check fallout of reserving unknown doc attributes

craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 3, 2026

Fix rust_logo feature gate

f4acea6

mejrs force-pushed the reserve_doc_attrs branch from 2447676 to f4acea6 Compare October 3, 2026 18:23

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Oct 3, 2026

Auto merge of #163699 - mejrs:reserve_doc_attrs, r=<try>

f3df2fe

[crater] check fallout of reserving unknown doc attributes

craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Oct 3, 2026

craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 3, 2026

theemathas mentioned this pull request Oct 11, 2026

Crater rollup #164148

Closed

craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Oct 11, 2026

craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 18, 2026

craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Oct 19, 2026

Conversation

mejrs commented Oct 3, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mejrs commented Oct 3, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Oct 3, 2026

Uh oh!

mejrs commented Oct 3, 2026

Uh oh!

craterbot commented Oct 3, 2026

Uh oh!

notriddle commented Oct 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mejrs commented Oct 3, 2026

Uh oh!

This comment has been minimized.

craterbot commented Oct 3, 2026

Uh oh!

rust-bors Bot commented Oct 3, 2026

Uh oh!

mejrs commented Oct 3, 2026

Uh oh!

craterbot commented Oct 3, 2026

Uh oh!

rust-bors Bot commented Oct 6, 2026

Uh oh!

theemathas commented Oct 11, 2026

Uh oh!

craterbot commented Oct 11, 2026

Uh oh!

theemathas commented Oct 18, 2026

Uh oh!

craterbot commented Oct 18, 2026

Uh oh!

craterbot commented Oct 19, 2026

Uh oh!

craterbot commented Oct 19, 2026

Footnotes

Uh oh!

notriddle commented Oct 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mejrs commented Oct 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

mejrs commented Oct 3, 2026 •

edited by rustbot

Loading

notriddle commented Oct 3, 2026 •

edited

Loading

notriddle commented Oct 21, 2026 •

edited

Loading

mejrs commented Oct 26, 2026 •

edited

Loading