impl Step for IP addresses by clarfonthey · Pull Request #113748 · rust-lang/rust

clarfonthey · 2023-07-16T03:19:03Z

View all comments

ACP: rust-lang/libs-team#235

Note: since this is insta-stable, it requires an FCP.

Separating out from the bit operations PR since it feels logically disjoint, and so their FCPs can be separate.

rustbot · 2023-07-16T03:19:11Z

r? @m-ou-se

(rustbot has picked a reviewer for you, use r? to override)

m-ou-se · 2023-08-15T14:04:32Z

@rfcbot merge

Even though the attributes say #[unstable] and the Step trait is still unstable, this trait impl results in changes on stable because we have stable APIs that use : Step as a bound. For example, after merging this PR, Range<Ipv4Addr> will implement Iterator, which means that for ip in ip1..ip2 will work.

rfcbot · 2023-08-15T14:04:33Z

Team member @m-ou-se has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

rfcbot · 2023-08-15T14:54:25Z

🔔 This is now entering its final comment period, as per the review above. 🔔

rfcbot · 2023-08-25T14:55:13Z

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

bors · 2023-09-02T02:23:51Z

☔ The latest upstream changes (presumably #113295) made this pull request unmergeable. Please resolve the merge conflicts.

dtolnay · 2023-09-16T15:29:21Z

@bors r+

bors · 2023-09-16T15:29:22Z

📌 Commit 8184c9c has been approved by dtolnay

It is now in the queue for this repository.

bors · 2023-09-16T20:22:24Z

⌛ Testing commit 8184c9c with merge c8b5754...

impl Step for IP addresses ACP: rust-lang/libs-team#235 Note: since this is insta-stable, it requires an FCP. Separating out from the bit operations PR since it feels logically disjoint, and so their FCPs can be separate.

bors · 2023-09-16T22:07:57Z

☀️ Test successful - checks-actions
Approved by: dtolnay
Pushing c8b5754 to master...

bors · 2023-09-16T22:08:56Z

👀 Test was successful, but fast-forwarding failed: 422 Update is not a fast forward

rust-timer · 2023-09-17T00:26:32Z

Finished benchmarking commit (c8b5754): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.4%	[0.3%, 0.4%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.4%	[2.4%, 2.4%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.9%	[-0.9%, -0.9%]	1
All ❌✅ (primary)	-	-	0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 632.183s -> 633.627s (0.23%)
Artifact size: 318.14 MiB -> 318.18 MiB (0.01%)

dtolnay · 2023-09-17T00:33:48Z

??

@bors retry

dtolnay · 2023-09-17T00:34:46Z

@bors r+

bors · 2023-09-17T00:34:48Z

💡 This pull request was already approved, no need to approve it again.

This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
There's another pull request that is currently being tested, blocking this pull request: Add implementation for thread::sleep_until #113753

bors · 2023-09-17T00:34:49Z

📌 Commit 8184c9c has been approved by dtolnay

It is now in the queue for this repository.

bors · 2023-09-17T06:27:11Z

⌛ Testing commit 8184c9c with merge 3ecc563...

bors · 2023-09-17T08:11:31Z

☀️ Test successful - checks-actions
Approved by: dtolnay
Pushing 3ecc563 to master...

rust-timer · 2023-09-17T09:32:34Z

Finished benchmarking commit (3ecc563): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.8%	[0.8%, 0.8%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 635.86s -> 635.641s (-0.03%)
Artifact size: 318.46 MiB -> 318.45 MiB (-0.00%)

Pkgsrc changes: * Remove NetBSD-8 support (embedded LLVm requires newer C++ than what is in -8; it's conceivable that this could still build with an external LLVM) * undo powerpc 9.0 file naming tweak, since we no longer support -8. * Remove patch to LLVM for powerpc now included by upstream. * Minor adjustments, checksum changes etc. Upstream changes: Version 1.74.1 (2023-12-07) =========================== - [Resolved spurious STATUS_ACCESS_VIOLATIONs in LLVM] (rust-lang/rust#118464) - [Clarify guarantees for std::mem::discriminant] (rust-lang/rust#118006) - [Fix some subtyping-related regressions] (rust-lang/rust#116415) Version 1.74.0 (2023-11-16) ========================== Language -------- - [Codify that `std::mem::Discriminant<T>` does not depend on any lifetimes in T] (rust-lang/rust#104299) - [Replace `private_in_public` lint with `private_interfaces` and `private_bounds` per RFC 2145] (rust-lang/rust#113126) Read more in [RFC 2145](https://rust-lang.github.io/rfcs/2145-type-privacy.html). - [Allow explicit `#[repr(Rust)]`] (rust-lang/rust#114201) - [closure field capturing: don't depend on alignment of packed fields] (rust-lang/rust#115315) - [Enable MIR-based drop-tracking for `async` blocks] (rust-lang/rust#107421) Compiler -------- - [stabilize combining +bundle and +whole-archive link modifiers] (rust-lang/rust#113301) - [Stabilize `PATH` option for `--print KIND=PATH`] (rust-lang/rust#114183) - [Enable ASAN/LSAN/TSAN for `*-apple-ios-macabi`] (rust-lang/rust#115644) - [Promote loongarch64-unknown-none* to Tier 2] (rust-lang/rust#115368) - [Add `i686-pc-windows-gnullvm` as a tier 3 target] (rust-lang/rust#115687) Libraries --------- - [Implement `From<OwnedFd/Handle>` for ChildStdin/out/err] (rust-lang/rust#98704) - [Implement `From<{&,&mut} [T; N]>` for `Vec<T>` where `T: Clone`] (rust-lang/rust#111278) - [impl Step for IP addresses] (rust-lang/rust#113748) - [Implement `From<[T; N]>` for `Rc<[T]>` and `Arc<[T]>`] (rust-lang/rust#114041) - [`impl TryFrom<char> for u16`] (rust-lang/rust#114065) - [Stabilize `io_error_other` feature] (rust-lang/rust#115453) - [Stabilize the `Saturating` type] (rust-lang/rust#115477) - [Stabilize const_transmute_copy] (rust-lang/rust#115520) Stabilized APIs --------------- - [`core::num::Saturating`] (https://doc.rust-lang.org/stable/std/num/struct.Saturating.html) - [`impl From<io::Stdout> for std::process::Stdio`] (https://doc.rust-lang.org/stable/std/process/struct.Stdio.html#impl-From%3CStdout%3E-for-Stdio) - [`impl From<io::Stderr> for std::process::Stdio`] (https://doc.rust-lang.org/stable/std/process/struct.Stdio.html#impl-From%3CStderr%3E-for-Stdio) - [`impl From<OwnedHandle> for std::process::Child{Stdin, Stdout, Stderr}`] (https://doc.rust-lang.org/stable/std/process/struct.Stdio.html#impl-From%3CStderr%3E-for-Stdio) - [`impl From<OwnedFd> for std::process::Child{Stdin, Stdout, Stderr}`] (https://doc.rust-lang.org/stable/std/process/struct.Stdio.html#impl-From%3CStderr%3E-for-Stdio) - [`std::ffi::OsString::from_encoded_bytes_unchecked`] (https://doc.rust-lang.org/stable/std/ffi/struct.OsString.html#method.from_encoded_bytes_unchecked) - [`std::ffi::OsString::into_encoded_bytes`] (https://doc.rust-lang.org/stable/std/ffi/struct.OsString.html#method.into_encoded_bytes) - [`std::ffi::OsStr::from_encoded_bytes_unchecked`] (https://doc.rust-lang.org/stable/std/ffi/struct.OsStr.html#method.from_encoded_bytes_unchecked) - [`std::ffi::OsStr::as_encoded_bytes`] (https://doc.rust-lang.org/stable/std/ffi/struct.OsStr.html#method.as_encoded_bytes) - [`std::io::Error::other`] (https://doc.rust-lang.org/stable/std/io/struct.Error.html#method.other) - [`impl TryFrom<char> for u16`] (https://doc.rust-lang.org/stable/std/primitive.u16.html#impl-TryFrom%3Cchar%3E-for-u16) - [`impl<T: Clone, const N: usize> From<&[T; N]> for Vec<T>`] (https://doc.rust-lang.org/stable/std/vec/struct.Vec.html#impl-From%3C%26%5BT;+N%5D%3E-for-Vec%3CT,+Global%3E) - [`impl<T: Clone, const N: usize> From<&mut [T; N]> for Vec<T>`] (https://doc.rust-lang.org/stable/std/vec/struct.Vec.html#impl-From%3C%26mut+%5BT;+N%5D%3E-for-Vec%3CT,+Global%3E) - [`impl<T, const N: usize> From<[T; N]> for Arc<[T]>`] (https://doc.rust-lang.org/stable/std/sync/struct.Arc.html#impl-From%3C%5BT;+N%5D%3E-for-Arc%3C%5BT%5D,+Global%3E) - [`impl<T, const N: usize> From<[T; N]> for Rc<[T]>`] (https://doc.rust-lang.org/stable/std/rc/struct.Rc.html#impl-From%3C%5BT;+N%5D%3E-for-Rc%3C%5BT%5D,+Global%3E) These APIs are now stable in const contexts: - [`core::mem::transmute_copy`] (https://doc.rust-lang.org/beta/std/mem/fn.transmute_copy.html) - [`str::is_ascii`] (https://doc.rust-lang.org/beta/std/primitive.str.html#method.is_ascii) - [`[u8]::is_ascii`] (https://doc.rust-lang.org/beta/std/primitive.slice.html#method.is_ascii) Cargo ----- - [fix: Set MSRV for internal packages] (rust-lang/cargo#12381) - [config: merge lists in precedence order] (rust-lang/cargo#12515) - [fix(update): Clarify meaning of --aggressive as --recursive] (rust-lang/cargo#12544) - [fix(update): Make `-p` more convenient by being positional] (rust-lang/cargo#12545) - [feat(help): Add styling to help output ] (rust-lang/cargo#12578) - [feat(pkgid): Allow incomplete versions when unambigious] (rust-lang/cargo#12614) - [feat: stabilize credential-process and registry-auth] (rust-lang/cargo#12649) - [feat(cli): Add '-n' to dry-run] (rust-lang/cargo#12660) - [Add support for `target.'cfg(..)'.linker`] (rust-lang/cargo#12535) - [Stabilize `--keep-going`] (rust-lang/cargo#12568) - [feat: Stabilize lints] (rust-lang/cargo#12648) Rustdoc ------- - [Add warning block support in rustdoc] (rust-lang/rust#106561) - [Accept additional user-defined syntax classes in fenced code blocks] (rust-lang/rust#110800) - [rustdoc-search: add support for type parameters] (rust-lang/rust#112725) - [rustdoc: show inner enum and struct in type definition for concrete type] (rust-lang/rust#114855) Compatibility Notes ------------------- - [Raise minimum supported Apple OS versions] (rust-lang/rust#104385) - [make Cell::swap panic if the Cells partially overlap] (rust-lang/rust#114795) - [Reject invalid crate names in `--extern`] (rust-lang/rust#116001) - [Don't resolve generic impls that may be shadowed by dyn built-in impls] (rust-lang/rust#114941) Internal Changes ---------------- These changes do not affect any public interfaces of Rust, but they represent significant improvements to the performance or internals of rustc and related tools. None this cycle.

rustbot assigned m-ou-se Jul 16, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 16, 2023

This comment has been minimized.

Sign in to view

clarfonthey force-pushed the ip-step branch from c1971f5 to 88333cf Compare July 16, 2023 03:23

clarfonthey mentioned this pull request Jul 16, 2023

ACP: Extended logic for IP networks rust-lang/libs-team#235

Closed

This comment has been minimized.

Sign in to view

clarfonthey force-pushed the ip-step branch from 88333cf to 7a3eef5 Compare July 16, 2023 04:50

the8472 added T-libs-api [DEPRECATED; DO NOT USE] needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 17, 2023

clarfonthey force-pushed the ip-step branch 2 times, most recently from 6dc3846 to 87bea1d Compare July 22, 2023 16:10

rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Aug 15, 2023

m-ou-se added S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 15, 2023

rfcbot added the final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. label Aug 15, 2023

rfcbot removed the proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. label Aug 15, 2023

This comment was marked as outdated.

Sign in to view

rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Aug 25, 2023

rfcbot added the to-announce Announce this issue on triage meeting label Aug 25, 2023

apiraino removed the to-announce Announce this issue on triage meeting label Sep 1, 2023

dtolnay assigned dtolnay and unassigned m-ou-se Sep 16, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 16, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 16, 2023

dtolnay closed this Sep 17, 2023

dtolnay reopened this Sep 17, 2023

bors merged commit 3ecc563 into rust-lang:master Sep 17, 2023

rustbot added this to the 1.74.0 milestone Sep 17, 2023

clarfonthey deleted the ip-step branch September 17, 2023 08:48

dtolnay mentioned this pull request Sep 27, 2023

impl Not, Bit{And,Or}{,Assign} for IP addresses #113747

Merged

clarfonthey added the A-iterators Area: Iterators label Nov 4, 2026

Conversation

clarfonthey commented Jul 16, 2023 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jul 16, 2023

Uh oh!

This comment has been minimized.

This comment has been minimized.

m-ou-se commented Aug 15, 2023

Uh oh!

rfcbot commented Aug 15, 2023 • edited by BurntSushi Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rfcbot commented Aug 15, 2023

Uh oh!

This comment was marked as outdated.

rfcbot commented Aug 25, 2023

Uh oh!

bors commented Sep 2, 2023

Uh oh!

dtolnay commented Sep 16, 2023

Uh oh!

bors commented Sep 16, 2023

Uh oh!

bors commented Sep 16, 2023

Uh oh!

bors commented Sep 16, 2023

Uh oh!

bors commented Sep 16, 2023

Uh oh!

rust-timer commented Sep 17, 2023

Overall result: ❌ regressions - no action needed

Uh oh!

dtolnay commented Sep 17, 2023

Uh oh!

dtolnay commented Sep 17, 2023

Uh oh!

bors commented Sep 17, 2023

Uh oh!

bors commented Sep 17, 2023

Uh oh!

bors commented Sep 17, 2023

Uh oh!

bors commented Sep 17, 2023

Uh oh!

rust-timer commented Sep 17, 2023

Overall result: no relevant changes - no action needed

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

clarfonthey commented Jul 16, 2023 •

edited by rustbot

Loading

rfcbot commented Aug 15, 2023 •

edited by BurntSushi

Loading