Skip to content

RELEASE.md does not mention the change to allow adding docs to reexported items #84007

Closed

Description

@rodrimati1992

At some point between Rust 1.34.0 and 1.39.0, the ability to add documentation to reexported items was added, but I can't find it mentioned in either the RELEASE notes or the rust-lang.org blog posts.

Maybe this should be mentioned in the RELEASE notes for the version that added that feature?

I have a foo crate that I use to test stuff, and used cargo +1.39.0 doc to document this:

/// Ooooh, ghost!
pub use std::marker::PhantomData;

image

Activity

  1. changed the title [-]Can't find mention of being able to add documentation to reexports in release notes[/-] [+]RELEASE.md does not mention the change to allow adding docs to reexported items[/+] on Apr 8, 2021
  2. added
    T-releaseRelevant to the release subteam, which will review and decide on the PR/issue.
    on Apr 8, 2021
  3. jyn514 commented on Apr 8, 2021

    @jyn514
    Member

    This was changed in 1.38 (coincidentally also the release rust-std spiked from a 61.2 MB to 173.3 MB download).

    @rodrimati1992 are you interested in making a PR?

  4. added
    T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.
    on Apr 8, 2021
  5. rodrimati1992 commented on Apr 8, 2021

    @rodrimati1992
    ContributorAuthor

    @jyn514 Sure, what are the PRs that made this possible?

  6. jyn514 commented on Apr 8, 2021

    @jyn514
    Member

    Oh I have no idea 😆 I found it by bisecting.

  7. rodrimati1992 commented on Apr 8, 2021

    @rodrimati1992
    ContributorAuthor

    Looks like #63048 is it

  8. added a commit that references this issue on Apr 9, 2021
    bc66b92
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    T-releaseRelevant to the release subteam, which will review and decide on the PR/issue.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions