regression: AsRef inference breakage #82665

Activity

1. Mark-Simulacrum

   added

   I-nominated

   T-libs-api[DEPRECATED; DO NOT USE][DEPRECATED; DO NOT USE]

   regression-from-stable-to-betaPerformance or correctness regression from stable to beta.Performance or correctness regression from stable to beta.

   on Mar 1, 2021
2. Mark-Simulacrum

   added this to the 1.51.0 milestone on Mar 1, 2021
3. rustbot

   added

   I-prioritizeIssue needs a team member to assess the impact. Will be replaced by P-{low,medium,high,critical}Issue needs a team member to assess the impact. Will be replaced by P-{low,medium,high,critical}

   on Mar 1, 2021
4. apiraino commented on Mar 3, 2021

   

   apiraino

   on Mar 3, 2021

   Contributor

   More actions

   I've tried bisecting this issue (if it helps):

   searched nightlies: from nightly-2021-01-01 to nightly-2021-03-03
   regressed nightly: nightly-2021-01-26
   searched commits: from 1d0d76f to f4eb5d9
   regressed commit: d3163e9

   bisected with cargo-bisect-rustc v0.6.0

   Host triple: x86_64-unknown-linux-gnu
   Reproduce with:

   cargo bisect-rustc --start=2021-01-01 

   somewhere in this rollup #81355
5. m-ou-se commented on Mar 3, 2021

   

   m-ou-se

   on Mar 3, 2021

   Member

   More actions

   somewhere in this rollup #81355

   Hm, none of the PRs in that rollup should affect AsRef for String, which is what all these regressions are about. There's only one trait implementation added in that rollup: impl Error for &(impl Error).
6. JohnTitor commented on Mar 5, 2021

   

   JohnTitor

   on Mar 5, 2021

   Member

   More actions

   This shows the regression (playground):

   use std::io;
   
   pub fn foo() -> io::Result<i32> {
       Err(io::Error::new(
           io::ErrorKind::Other,
           format!("Error!").as_ref(),
       ))
   }
   
   fn main() {}

   And yes, confirmed that #75180 is the cause.
7. apiraino

   removed

   I-prioritizeIssue needs a team member to assess the impact. Will be replaced by P-{low,medium,high,critical}Issue needs a team member to assess the impact. Will be replaced by P-{low,medium,high,critical}

   on Mar 5, 2021
8. LeSeulArtichaut commented on Mar 5, 2021

   

   LeSeulArtichaut

   on Mar 5, 2021

   Contributor

   More actions

   It looks like those were expected regressions (see #75180 (comment)).
9. JohnTitor commented on Mar 22, 2021

   

   JohnTitor

   on Mar 22, 2021

   Member

   More actions

   Triage: Close this issue as an acceptable regression, we mentioned it in #75180 (comment) and consider it acceptable through FCP.
10. JohnTitor

    closed this as completedon Mar 22, 2021