Skip to content

Add support for worktrees to x.py setup git hook #77684

Closed

Description

@jyn514

.git doesn't exist for worktrees. x.py setup should use git rev-parse --git-common-dir instead.

x.py encountered an error -- do you already have the git hook installed?
Not a directory (os error 20)

Originally posted by @jyn514 in #76356 (comment)

Activity

  1. added
    A-contributor-roadblockArea: Makes things more difficult for new or seasoned contributors to Rust
    on Oct 7, 2020
  2. jyn514 commented on Oct 7, 2020

    @jyn514
    MemberAuthor

    Actually maybe this shouldn't run at all for worktrees since it applies globally to all worktrees and everything else x.py setup does currently is local to a worktree ...

  3. added
    T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
    on Oct 7, 2020
  4. added
    C-feature-requestCategory: A feature request, i.e: not implemented / a PR.
    on Oct 16, 2020
  5. added a commit that references this issue on Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-contributor-roadblockArea: Makes things more difficult for new or seasoned contributors to RustC-feature-requestCategory: A feature request, i.e: not implemented / a PR.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions