Make references to GitHub issues in diagnostics consistent #62976

Activity

1. shepmaster

   added

   E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

   A-diagnosticsArea: Messages for errors, warnings, and lintsArea: Messages for errors, warnings, and lints

   on Jul 25, 2019
2. shepmaster commented on Jul 25, 2019

   

   shepmaster

   on Jul 25, 2019

   MemberAuthor

   More actions

   General steps:

   1. Do some initial review of the *.stderr files in src/test/ui and see how many distinct patterns there are. I'd say this requires some knowledge of command line text processing.

   2. Identify the sources of each distinct pattern in the source code and unify them.

   3. The tests will need to be updated with the new diagnostics.
3. punitkoura commented on Jul 25, 2019

   

   punitkoura

   on Jul 25, 2019

   More actions

   @shepmaster I'd like to take this up. Seems like a good first contribution to Rust.
   Do we have an ETA for this?
4. shepmaster commented on Jul 25, 2019

   

   shepmaster

   on Jul 25, 2019

   MemberAuthor

   More actions

   @punitkoura that’s wonderful! ❤️

   Do we have an ETA for this?

   I don’t think there’s any rush; it was mostly a minor annoyance I had when maintaining the playground.

   👍React with 👍1Reacted by Punit Singh Koura
5. punitkoura commented on Jul 26, 2019

   

   punitkoura

   on Jul 26, 2019

   More actions

   I did an initial pass finding the different types of patterns of referencing Github issues. I was able to find 8 different types as follows -

   (base) C02XF1TZJHD3:rust pkoura$ grep -rh --include "*.stderr" "/issues/" src/test/ui | sed -E 's/\#[0-9]+/#<ISSUE>/g' | sed -E 's/issues\/[0-9]+/issues\/<ISSUE>/g' | sort -u
              see https://github.com/rust-lang/rust/issues/<ISSUE> for more details
      = note: for more information, see https://github.com/rust-lang/rust/issues/<ISSUE>
      = note: for more information, see issue #<ISSUE> <https://github.com/rust-lang/rust/issues/<ISSUE>>
      = note: for more information, see issue https://github.com/rust-lang/rust/issues/<ISSUE>
      = note: the trait is implemented for `()`. Possibly this error has been caused by changes to Rust's type-inference algorithm (see: https://github.com/rust-lang/rust/issues/<ISSUE> for more info). Consider whether you meant to use the type `()` here instead.
   error: use of deprecated attribute `no_debug`: the `#[no_debug]` attribute was an experimental feature that has been deprecated due to lack of demand. See https://github.com/rust-lang/rust/issues/<ISSUE>
   note: use of `&&` operator here does not actually short circuit due to the const evaluator presently not being able to do control flow. See https://github.com/rust-lang/rust/issues/<ISSUE> for more information.
   warning: use of deprecated attribute `no_debug`: the `#[no_debug]` attribute was an experimental feature that has been deprecated due to lack of demand. See https://github.com/rust-lang/rust/issues/<ISSUE>

   👍React with 👍2Reacted by eupn and Sorenson Stallings
6. punitkoura commented on Jul 26, 2019

   

   punitkoura

   on Jul 26, 2019

   More actions

   Will focus now on identifying the sources of these patterns in the source code.
7. eupn commented on Jul 26, 2019

   

   eupn

   on Jul 26, 2019

   Contributor

   More actions

   @shepmaster please take a look at #63008 PR. @punitkoura, thanks for a list of patterns, you might take a look as well.

   👍React with 👍2Reacted by Punit Singh Koura and Sorenson Stallings
8. varkor commented on Jul 31, 2019

   

   varkor

   on Jul 31, 2019

   Contributor

   More actions

   @punitkoura: if you want help finding another good issue to work on, feel free to send me a message on Discord or Zulip. Any of the E-easy or E-mentor issues are good choices, though.

   👍React with 👍2Reacted by Punit Singh Koura and Sorenson Stallings
9. punitkoura commented on Jul 31, 2019

   

   punitkoura

   on Jul 31, 2019

   More actions

   Thanks @varkor. I'll be on the lookout 🙂
10. Centril

    added a commit that references this issue on Jul 31, 2019

    Rollup merge of rust-lang#63008 - eupn:consistent-see-issue, r=varkor

    ...

    This issue will close once commit 07675af is merged into the 'master' branch.

    07675af
11. JohnTitor

    added

    C-enhancementCategory: An issue proposing an enhancement or a PR with one.Category: An issue proposing an enhancement or a PR with one.

    T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.

    on Oct 2, 2019
12. Dylan-DPC-zz

    added a commit that references this issue on Feb 8, 2020

    Rollup merge of rust-lang#68929 - matprec:consistent-issue-references…

    ...

    a9a7da7
13. bors

    added a commit that references this issue on Feb 11, 2020

    Auto merge of #68929 - matprec:consistent-issue-references, r=Dylan-DPC

    ...

    dc4242d
14. bors

    closed this as completedin dc4242don Feb 11, 2020