Repository navigation
Deprecate try! macro in favor of ? #61000
Description
I propose to mark the try! macro as deprecated.
Reasons for it:
?was stabilized in 1.13, November 2016. 2+years ago- there is an interest in having a lint for replacing
try!with?for 2+years tryis a keyword in rust 2018 and needs to be written asr#try!- ""The Rust Programming Language", 2nd edition (book) and "Rust by Example" have both already removed all mentions of
try!." - the doc of
try!literally names the definition of deprecation
The
?operator was added to replacetry!and should be used instead.
There are no real downsides 😃
(I am happy to wait for #37939 ;)
Reacted by Aaron Hill, Sander Maijers, scottmcm, RustyYato, Abid Omar, Baran Bartu Demirci and Chuigda Whitegive
Reacted by Thiez
Activity
Centril commentedon May 21, 2019
I did some investigation on the playground and it seems that the reason
r#try!isn't deprecated yet is becausemacro_rules!cannot be deprecated at all. cc @petrochenkovpetrochenkov commentedon May 21, 2019
The issue is #49912, someone (not me) needs to do the work.
petrochenkov commentedon May 21, 2019
It can work at any point if name resolution results are available.
Stability checking is already implemented for macros and deprecation checking can be done by analogy.
Rollup merge of rust-lang#62042 - petrochenkov:macstab, r=matthewjasper
Rollup merge of rust-lang#62042 - petrochenkov:macstab, r=matthewjasper
tesuji commentedon Jul 14, 2019
I take this in #62672 .
Rollup merge of rust-lang#62672 - lzutao:deprecated-try-macro, r=Centril