Skip to content

regression: cycle detected when computing whether impls specialize one another #125197

New issue
New issue
Closed
Closed
regression: cycle detected when computing whether impls specialize one another#125197
Assignees
compiler-errors
Labels
A-specializationArea: Trait impl specializationF-specialization`#![feature(specialization)]`T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.regression-from-stable-to-betaPerformance or correctness regression from stable to beta.
Milestone
1.79.0

Description

@BoxyUwU
BoxyUwU
opened on May 17, 2024
[INFO] [stdout] error[E0391]: cycle detected when computing whether impls specialize one another
[INFO] [stdout]   --> /opt/rustwide/workdir/src/lib.rs:54:1
[INFO] [stdout]    |
[INFO] [stdout] 54 | impl<T: Identifier> PartialEq<T> for AnyId {
[INFO] [stdout]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |

Activity

  1. BoxyUwU
    added
    T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
    regression-from-stable-to-betaPerformance or correctness regression from stable to beta.
    on May 17, 2024
  2. rustbot
    added
    I-prioritizeIssue needs a team member to assess the impact. Will be replaced by P-{low,medium,high,critical}
    needs-triageThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triaging
    on May 17, 2024
  3. BoxyUwU
    added this to the 1.79.0 milestone on May 17, 2024

  4. compiler-errors commented on May 17, 2024

    @compiler-errors
    compiler-errors
    on May 17, 2024
    Contributor

    Bisecting this...

  5. compiler-errors commented on May 17, 2024

    @compiler-errors
    compiler-errors
    on May 17, 2024
    Contributor

    This bisected in #122791. This crate is using specialization, which we don't stably support.

    This has some interactions with specialization, and so breaks a few UI tests that I don't agree should've ever worked in the first place, and also breaks a handful of crates in a way that I don't believe is a problem.

  6. compiler-errors
    added
    P-lowLow priority
    and removed
    I-prioritizeIssue needs a team member to assess the impact. Will be replaced by P-{low,medium,high,critical}
    on May 17, 2024
  7. Noratrieb
    added
    A-specializationArea: Trait impl specialization
    F-specialization`#![feature(specialization)]`
    and removed
    needs-triageThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triaging
    on May 17, 2024

  8. Mark-Simulacrum commented on Jun 7, 2024

    @Mark-Simulacrum
    Mark-Simulacrum
    on Jun 7, 2024
    Member

    @compiler-errors How is that not feature gated? I don't see feature gates in the repos above and presumably it built on stable in order to regress here?

  9. compiler-errors commented on Jun 7, 2024

    @compiler-errors
    compiler-errors
    on Jun 7, 2024
    Contributor

    I am mistaken then, @Mark-Simulacrum. I thought I looked at these crates, but perhaps I was looking at the wrong one.

  10. compiler-errors commented on Jun 7, 2024

    @compiler-errors
    compiler-errors
    on Jun 7, 2024
    Contributor

    I'll look back into this...

  11. compiler-errors
    self-assigned this
    on Jun 7, 2024

  12. compiler-errors commented on Jun 7, 2024

    @compiler-errors
    compiler-errors
    on Jun 7, 2024
    Contributor

    Opened a PR for this and nominated for beta.

  13. bors
    added a commit that references this issue on Jun 7, 2024

    Auto merge of rust-lang#126139 - compiler-errors:specializes, r=<try>

    20182a9
  14. compiler-errors
    added
    I-prioritizeIssue needs a team member to assess the impact. Will be replaced by P-{low,medium,high,critical}
    and removed
    P-lowLow priority
    on Jun 7, 2024
  15. bors
    added a commit that references this issue on Jun 11, 2024

    Auto merge of rust-lang#126139 - compiler-errors:specializes, r=lcnr

    336e6ab
  16. apiraino
    removed
    I-prioritizeIssue needs a team member to assess the impact. Will be replaced by P-{low,medium,high,critical}
    on Jun 11, 2024
  17. github-actions
    added a commit that references this issue on Jun 13, 2024

    Auto merge of #126139 - compiler-errors:specializes, r=lcnr

    5cc316c
  18. flip1995
    added a commit that references this issue on Jun 28, 2024

    Auto merge of #126139 - compiler-errors:specializes, r=lcnr

    5d295a2

  19. apiraino commented on Aug 5, 2024

    @apiraino
    apiraino
    on Aug 5, 2024
    Contributor

    #126772 was merged, so can this be closed as fixed? cc @BoxyUwU

  20. compiler-errors commented on Aug 5, 2024

    @compiler-errors
    compiler-errors
    on Aug 5, 2024
    Contributor

    ya this was fixed

  21. compiler-errors
    closed this as completedon Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

A-specializationArea: Trait impl specializationF-specialization`#![feature(specialization)]`T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.regression-from-stable-to-betaPerformance or correctness regression from stable to beta.

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions