Skip to content

Bootstrap: Changelog not displayed when config fails to parse #121756

Closed

Description

@TimNN

Bootstrap's "changelog" functionality can be quite helpful in figuring out how to adapt a local config.toml file for bootstrap changes.

However, before checking whether the changelog needs to be displayed, bootstrap currently fully parses and validates the config. This means that if there is an error while parsing the config, the changelog is never displayed.

I ran into this recently when the codegen profile was removed (the profile must be successfully resolved to parse the config, so the changelog was never displayed), and again while writing #121754 (where I'd ideally like to remove a field from the config, but kept it for now to be able to provide a better error message).

IMO bootstrap would ideally check whether the changelog needs to be displayed before fully parsing the config.

Activity

  1. added
    needs-triageThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triaging
    on Feb 28, 2024
  2. added
    C-enhancementCategory: An issue proposing an enhancement or a PR with one.
    T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
    and removed
    C-bugCategory: This is a bug.
    needs-triageThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triaging
    on Feb 28, 2024
  3. self-assigned this
    on Feb 29, 2024
  4. added a commit that references this issue on Mar 17, 2024
    2448162
  5. added a commit that references this issue on Mar 17, 2024
    5b51f20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

C-enhancementCategory: An issue proposing an enhancement or a PR with one.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions