You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Resolving remaining concerns with Pin docs #119714
#116129 was landed with some outstanding concerns, since it was considered to be an improvement over the status quo despite those concerns. Would be good to further improve the docs and resolve those concerns. :) The text also changed a bit since the concerns were originally raised, so we have to re-evaluate if they still apply.
This thread is about the concern that the description of Unpin focuses too much on describing the effects of !Unpin rather than Unpin.
This thread is about the docs basically re-telling the story of how we arrived at Pin, with various twists and turns, which might not be the best way to explain how to work with the final design. The historical part should possibly be moved further down in the docs.
This thread is about the interaction of structural pinning and Unpin.
This thread is about the claim that Unpin types will "not expose nor rely on any pinning guarantees", which is not quite correct.
This thread is about the "pinboard" analogy not being evocative or necessarily very useful.
Activity
Manishearth commentedon Jan 7, 2024
I think for (1) someone should probably rearrange the Unpin docs to talk about Unpin first and then talk about
!Unpin.For (2) we should move that story to the end and reference it prominently.