Cannot dyn upcast to target w/ auto traits implied by source's principal's supertraits

@Ekleog

Originally posted by @Ekleog in #65991 (comment)

I just tried using this feature to upcast to Any + Send + Sync, and it seems to me like this is currently not allowed:

trait DynSized: 'static + Any + Send + Sync + DeepSizeOf {}
impl<T: 'static + Any + Send + Sync + DeepSizeOf> DynSized for T {}

fn main() {
    let ptr = Arc::new(()) as Arc<dyn DynSized>;
    let ptr_any = ptr as Arc<dyn Any + Send + Sync>;
    // my goal:
    let res = Arc::<dyn Any + Send + Sync>::downcast::<()>(ptr);
}

(playground link)

With references, the situation does not seem better than with Arc: this does not compile either

fn main() {
    let ptr = &() as &'static dyn DynSized;
    let ptr_any = ptr as &'static (dyn Any + Send + Sync);
}

(playground link)

Is this expected? I can't find any reference to this limitation, neither explicitly in the RFC text nor in this tracking issue. The RFC text does mention not supporting upcasting to multiple traits, but I'd have expected lifetimes as well as auto traits to not be included in the limitation.

If it is expected that this feature is stabilized without this support, does anyone know where I should watch, to know of the news on that front?

Minimized:

trait Source: Send + Target {}

fn upcast(x: &dyn Source) -> &(dyn Target + Send) { x }

We should be able to upcast to a dyn type w/ auto-traits that show up in the principal's supertraits too.

@rustbot

I'll fix it.

@rustbot claim

This would be awesome, thank you so much for looking into it! ❤️

This includes the previously unsupported dyn Source => dyn Source + Send coercion, right? I think it's a good enhancement.

@crlf0710

@crlf0710: Yes, if Source has Send as one of its supertraits.

A more minimal example:

trait AnySendSync: Any + Send + Sync {}
impl<T: Any + Send + Sync> AnySendSync for T {}

fn main() {
    let ptr = &() as &dyn AnySendSync;
    // Compile error, unless you remove the "+ Send + Sync" part
    let ptr = ptr as &(dyn Any + Send + Sync);
}

This got fixed.

Navigation Menu

Repository navigation

Cannot dyn upcast to target w/ auto traits implied by source's principal's supertraits #119335

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Cannot dyn upcast to target w/ auto traits implied by source's principal's supertraits #119335

Description

Activity

compiler-errors commented on Dec 27, 2023

Ekleog commented on Dec 27, 2023

crlf0710 commented on Dec 27, 2023

compiler-errors commented on Dec 27, 2023

PoignardAzur commented on Jan 25, 2024

compiler-errors commented on Jan 3, 2025

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions