Skip to content

test: cover behaviors that change in libgit2 v2 - #1329

Merged
weihanglo merged 1 commit into
rust-lang:mainfrom
weihanglo:v2-behavior-tests
Nov 1, 2026
Merged

weihanglo merged 1 commit into
rust-lang:mainfrom
weihanglo:v2-behavior-tests

Conversation

@weihanglo

Copy link
Copy Markdown
Member

Pin today's behavior so the libgit2 2.0 bump shows each change as a diff in these assertions:

Pin today's behavior so the libgit2 2.0 bump shows each change
as a diff in these assertions:

* `Reference` equality ignores the name;
  libgit2 2.0 compares it first.
  libgit2/libgit2#6346
  https://github.com/libgit2/libgit2/blob/f28579db11737eaa2ced18498e229967a12f1c3f/src/libgit2/refs.c#L1100-L1111
* `RepositoryInitOptions::workdir_path` puts the repository at `<path>/.git`;
  libgit2 2.0 uses `<path>` itself.
  libgit2/libgit2#6982
  https://github.com/libgit2/libgit2/blob/f28579db11737eaa2ced18498e229967a12f1c3f/src/libgit2/repository.c#L2751-L2754
* `ConfigLevel::ProgramData` has a search path;
  libgit2 2.0 no longer reads it.
  libgit2/libgit2#7329
  https://github.com/libgit2/libgit2/blob/f28579db11737eaa2ced18498e229967a12f1c3f/include/git2/deprecated.h#L313-L315
@rustbot rustbot added the S-waiting-on-review Status: Waiting on review label Nov 1, 2026
@weihanglo
weihanglo added this pull request to the merge queue Nov 1, 2026
Merged via the queue into rust-lang:main with commit b9d59b6 Nov 1, 2026
12 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Waiting on review label Nov 1, 2026
@weihanglo
weihanglo deleted the v2-behavior-tests branch November 1, 2026 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants