Skip to content

fix!: remove more deprecated - #1327

Merged
weihanglo merged 3 commits into
rust-lang:mainfrom
weihanglo:remove-more-deprecated
Oct 31, 2026
Merged

weihanglo merged 3 commits into
rust-lang:mainfrom
weihanglo:remove-more-deprecated

Conversation

@weihanglo

Copy link
Copy Markdown
Member

libgit2-sys

  • git_indexer_hash, replaced by git_indexer_name
  • GIT_OID_HEXSZ, replaced by GIT_OID_SHA1_HEXSIZE
  • GIT_OID_RAWSZ, replaced by GIT_OID_SHA1_SIZE
  • git_packbuilder_hash, replaced by git_packbuilder_name

git2

  • PackBuilder::hash(), replaced by PackBuilder::name()

It has been deprecated since 0.14 in favor of `PackBuilder::name`,
and 0.22 is a breaking release anyway.
The tests keep their `name()` assertions.
0.19 is a breaking release anyway,
so drop these bindings that were already deprecated:

* `GIT_OID_RAWSZ` and `GIT_OID_HEXSZ`:
  use `GIT_OID_SHA1_SIZE` and `GIT_OID_SHA1_HEXSIZE`.
* `git_packbuilder_hash`: use `git_packbuilder_name`.
* `git_indexer_hash`: use `git_indexer_name`.

git2 no longer uses any of them.
@rustbot rustbot added the S-waiting-on-review Status: Waiting on review label Oct 31, 2026
@weihanglo
weihanglo force-pushed the remove-more-deprecated branch from 4597534 to 2698013 Compare October 31, 2026 14:47
@weihanglo
weihanglo enabled auto-merge October 31, 2026 14:50
@weihanglo
weihanglo added this pull request to the merge queue Oct 31, 2026
Merged via the queue into rust-lang:main with commit 6402036 Oct 31, 2026
12 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Waiting on review label Oct 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants