Repository navigation
Stabilize C-variadic function definitions - #727
Merged
Merged
Conversation
kirtchev-adacore
force-pushed
the
pr/kirtchev/c-variadic-functions
branch
5 times, most recently
from
September 28, 2026 07:54
463bbfe to
8b6b413
Compare
kirtchev-adacore
marked this pull request as ready for review
September 28, 2026 08:01
Contributor
Author
|
@PLeVasseur @tshepang Attributes |
kirtchev-adacore
force-pushed
the
pr/kirtchev/c-variadic-functions
branch
2 times, most recently
from
September 28, 2026 08:21
b7a9662 to
e90f5ae
Compare
tshepang
reviewed
Oct 1, 2026
This comment has been minimized.
This comment has been minimized.
tshepang
force-pushed
the
pr/kirtchev/c-variadic-functions
branch
from
October 6, 2026 16:42
caed066 to
d7aaa6d
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Member
|
added changes corresponding to rust-lang/reference#2321, and updated changelog to cover changes in the first commit |
bors-ferrocene Bot
added a commit
to ferrocene/ferrocene
that referenced
this pull request
Oct 9, 2026
2618: [1.99] [869apdayd] Backport FLS changes for Rust 1.99 r=Hoverbear a=fs-rachel Manually backport #2603 + pending changes from rust-lang/fls#727 Ferrocene-backport-of: #2603 Co-authored-by: kirtchev-adacore <kirtchev@adacore.com> Co-authored-by: Tshepang Mbambo <tshepang.mbambo@ferrous-systems.com> Co-authored-by: Tshepang Mbambo <hopsi@tuta.io> Co-authored-by: Pete LeVasseur <plevasseur@gmail.com>
bors-ferrocene Bot
added a commit
to ferrocene/ferrocene
that referenced
this pull request
Oct 10, 2026
2618: [1.99] [869apdayd] Backport FLS changes for Rust 1.99 r=Hoverbear a=fs-rachel Manually backport #2603 + pending changes from rust-lang/fls#727 Ferrocene-backport-of: #2603 Co-authored-by: kirtchev-adacore <kirtchev@adacore.com> Co-authored-by: Tshepang Mbambo <tshepang.mbambo@ferrous-systems.com> Co-authored-by: Tshepang Mbambo <hopsi@tuta.io> Co-authored-by: Pete LeVasseur <plevasseur@gmail.com>
tshepang
reviewed
Oct 20, 2026
PLeVasseur
requested changes
Oct 22, 2026
Contributor
There was a problem hiding this comment.
Thanks for this, @kirtchev-adacore. I can see it's quite complex. I've left some comments that I'd ask you to look at. Perhaps we go over this tomorrow in our meeting too.
PLeVasseur
added
the
I-fls-nominated
PLeVasseur
requested changes
Oct 26, 2026
tshepang
reviewed
Oct 27, 2026
tshepang
reviewed
Oct 27, 2026
PLeVasseur
requested changes
Oct 27, 2026
PLeVasseur
approved these changes
Oct 28, 2026
Contributor
There was a problem hiding this comment.
Looks good to me. Thank you for this, @kirtchev-adacore!
Contributor
|
~ DO NOT MERGE YET ~ @kirtchev-adacore will update the changelog 👍 |
kirtchev-adacore
force-pushed
the
pr/kirtchev/c-variadic-functions
branch
2 times, most recently
from
October 29, 2026 08:30
867e127 to
303e87a
Compare
Contributor
Author
|
I have updated the changelog entries. |
tshepang
reviewed
Oct 29, 2026
tshepang
reviewed
Oct 29, 2026
This PR adds FLS rules that stem from [Stabilize C-variadic function definitions](rust-lang/rust#155697) and [rust-lang/reference PR 2177](rust-lang/reference#2177).
kirtchev-adacore
force-pushed
the
pr/kirtchev/c-variadic-functions
branch
from
October 29, 2026 11:44
303e87a to
6668636
Compare
tshepang
approved these changes
Oct 30, 2026
PLeVasseur
approved these changes
Oct 30, 2026
bors-ferrocene Bot
added a commit
to ferrocene/ferrocene
that referenced
this pull request
Nov 2, 2026
2676: [1.99] fls: incorporate latest upstream updates r=fs-rachel a=tshepang rust-lang/fls#727 has since been updated with improvements and fixes, so this pr manually includes those changes (on top of #2618) Co-authored-by: Tshepang Mbambo <tshepang.mbambo@ferrous-systems.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds FLS rules that stem from Stabilize C-variadic function definitions.