Skip to content

Use English source and stable localization message IDs - #2

Merged
shiqimei merged 1 commit into
mainfrom
refactor/english-source
Nov 11, 2026
Merged

shiqimei merged 1 commit into
mainfrom
refactor/english-source

Conversation

@shiqimei

Copy link
Copy Markdown
Collaborator

Fennec mixed Chinese implementation/documentation with translated UI copy and used Chinese sentences as translation keys. This moves UI messages into one catalog with stable English IDs and converts project/developer documentation to English while preserving necessary Unicode test fixtures.

The build generates WebView locale data and a compiled native English fallback from the same catalog. Native dialogs, dynamic WebView labels, accessible attributes, and cloned controls keep their message identities across locale changes; user names, session titles, typed input, and terminal output remain untouched. make check now rejects CJK source/documentation outside explicit resources/fixtures and catches missing message references.

Documentation retains acceptance status and historical evidence. Magpie initialization wording is aligned with the already-implemented first-run/saved-choice policy in the project skill and audit; this does not change runtime defaults.

Validation:

  • make check, make check-ui, and focused Go race suites pass.
  • Native Foundation bundle tests cover the supported locales and missing-resource English fallback.
  • Browser rendering with an isolated native-bridge fixture covered all six locales, unchanged user content, and cloned Magpie tooltip updates without message-key leakage.
  • Signed macOS staging build, control contract, and package verification pass. The user's installed app and settings were not replaced.

@shiqimei
shiqimei merged commit 9bad837 into main Nov 11, 2026
4 checks passed
@shiqimei
shiqimei deleted the refactor/english-source branch November 11, 2026 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant