Repository navigation
Use English source and stable localization message IDs - #2
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fennec mixed Chinese implementation/documentation with translated UI copy and used Chinese sentences as translation keys. This moves UI messages into one catalog with stable English IDs and converts project/developer documentation to English while preserving necessary Unicode test fixtures.
The build generates WebView locale data and a compiled native English fallback from the same catalog. Native dialogs, dynamic WebView labels, accessible attributes, and cloned controls keep their message identities across locale changes; user names, session titles, typed input, and terminal output remain untouched.
make checknow rejects CJK source/documentation outside explicit resources/fixtures and catches missing message references.Documentation retains acceptance status and historical evidence. Magpie initialization wording is aligned with the already-implemented first-run/saved-choice policy in the project skill and audit; this does not change runtime defaults.
Validation:
make check,make check-ui, and focused Go race suites pass.