Repository navigation
revert: instances create --volume-mode copy|mount_ro (#15) - #16
Merged
Merged
Conversation
Volumes go back to copy only: the API no longer offers a read-only mount, so the flag, its validation, the request field, the schedule guard, the README text and the tests go. The CLI behaves as v0.11.0 for volumes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Volumes go back to copy only (decision: Shopon, 8 Nov 2026). Reverts #15 (401a974, the only change in v0.12.0 over v0.11.0), so the CLI behaves as v0.11.0 for volumes.
Removed: the --volume-mode flag on instances create and schedule create, its validation, the volume_mode request field, the schedule job guard entry, the Volume line mode suffix, the help text and example, the README section, and their tests. Nothing else touched.
Checks: go vet ./..., go test ./... (api, auth, commands, config pass), make build; the built binary has no volume-mode in instances create --help. Not tagged or released: next release is v0.13.0, after review.