Skip to content

Add entries for new suppression endpoints - #73

Merged
mrinehart-rz merged 1 commit into
mainfrom
suppression-endpoints
Sep 15, 2026
Merged

mrinehart-rz merged 1 commit into
mainfrom
suppression-endpoints

Conversation

@mrinehart-rz

Copy link
Copy Markdown
Contributor

Adds entries for the following endpoints:

  • POST /org/vulnerabilities/suppress
  • POST /org/vulnerability-groups/suppress
  • POST /org/findings/suppress

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Update the 207 response schemas to represent the documented partial suppression results.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

Adds OpenAPI entries for three organization-level suppression endpoints.

Changes:

  • Documents vulnerability, vulnerability-group, and finding suppression endpoints.
  • Adds request and response schemas.
  • Documents authentication and error responses.
File summaries
File Summary
go/api/openapi.yaml Defines the new endpoints and schemas. Moderate issue (3 votes): 207 responses at lines 1998, 2057, and 2116 use the generic Problem schema instead of exposing partial suppression results.
Review details

Suppressed comments (2)

go/api/openapi.yaml:2057

  • The 207 response is described as containing partial suppression results, but it is modeled as the generic RFC 7807 Problem. That prevents clients from seeing the suppressed, unsuppressed, and per-item errors fields provided by SuppressionResponse; use the result schema for this response (or define a dedicated partial-results schema matching the actual payload).
                $ref: "#/components/schemas/Problem"

go/api/openapi.yaml:2116

  • The 207 response is described as containing partial suppression results, but it is modeled as the generic RFC 7807 Problem. That prevents clients from seeing the suppressed, unsuppressed, and per-item errors fields provided by SuppressionResponse; use the result schema for this response (or define a dedicated partial-results schema matching the actual payload).
                $ref: "#/components/schemas/Problem"
  • Files reviewed: 1/1 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread go/api/openapi.yaml
@mrinehart-rz
mrinehart-rz merged commit 8026174 into main Sep 15, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants