Skip to content

fix(lore-0144): take the board's owner from an owner field - #180

Open
karczuRF wants to merge 2 commits into
developfrom
lore-0144-board-owner-field
Open

karczuRF wants to merge 2 commits into
developfrom
lore-0144-board-owner-field

Conversation

@karczuRF

Copy link
Copy Markdown
Collaborator

Summary

Task 0144: the board took a task's owner from the who of its last history entry, so a note from anyone else handed them the task. Closing 0029 put Karol on 0026, which I run. A task now names its owner in an owner: field, as the team agreed.

  • The rule (tools/scripts/generate-lore-board.mjs): the board shows owner when it is set and the last history who when it is not; a backlog task shows nobody. Blocked tasks now show their owner too.
  • One copy of it (lore/board.html): the page reads the assignee the script writes to board.json instead of working it out again.
  • A typo check (the script, run by pnpm board, the board deploy and now PR CI): it stops when an owner isn't a key of lore/0-session/team.yaml.
  • The fill: the 13 open tasks get owner as the board shows them today, except 0026, which is mine.
  • Who sets it (lore/1-tasks/_template.md, lore/1-tasks/CLAUDE.md, lore/1-tasks/active/CLAUDE.md, the promote-task and pr skills): activating sets it, a handoff changes it with a "Handoff from …" entry, and a note in someone else's task never does.

Reviewers, please confirm:

  • @karolko9 (0049, 0063, 0074, 0101, 0129, 0130, 0141): your tasks get owner: karolkow, and the board shows you as before. From now on a note you add to someone else's task, as on 0026, doesn't change its owner.
  • @adamkoot (0060, 0136): your tasks get owner: akot; the board shows you as before.
  • @stkrolikiewicz (0138): your task gets owner: stkrolikiewicz; the board shows you as before.

Please confirm

  1. Blocked tasks show their owner (all lanes): until now a blocked task showed nobody, so 0034 looked unassigned and a filter by name hid it. It now shows okarcz.
  2. Archived tasks show their owner, not their closer (all lanes): the owner did the work, even when someone else's PR closes the task. Tasks closed before this have no owner and look the same as before.
  3. A bad owner fails the PR (all lanes): CI runs pnpm board, so an owner that isn't in team.yaml stops the pull request, not the board deploy after it.
  4. Two lore plugin files changed (all lanes): lore/1-tasks/_template.md and lore/1-tasks/CLAUDE.md came with the lore plugin; reinstalling it could overwrite the owner lines.

Testing

  • pnpm board, before and after: 135 of 137 tasks keep their assignee; 0026 goes from karolkow to okarcz, and the blocked 0034 from none to okarcz.
  • pnpm board with owner: okracz in 0144: stops with owner "okracz" is not a key of lore/0-session/team.yaml, exit 1.
  • A backlog task made from the new template: the board builds, and it shows nobody.
  • pnpm format:check (tracked files), pnpm lint, pnpm typecheck, pnpm build → pass. pnpm test not run locally: no package code changes; CI runs it.
  • Testnet: N/A — tooling and docs only: the board script, its page and the task files.
  • A code review of the branch ran before this PR; its fixes are the second commit.

The board showed the who of a task's last history entry, so a note from
anyone else handed them the task: closing 0029 put Karol on 0026. A task
now names its owner in an owner field, read first, with the last who as
the fallback; blocked tasks show theirs too. board.html reads the
script's assignee instead of keeping its own copy of the rule, and the
script stops when an owner isn't a key of team.yaml.

The 13 open tasks get owner as the board shows them today, but 0026 is
okarcz's. The template, lore/1-tasks/CLAUDE.md and the promote-task and
pr skills say who sets it.
From the code review of this branch.

The board script's owner check ran only in the deploy after merge, so
a typo would pass the PR and then fail every board deploy until fixed;
CI now runs it. The template leaves owner empty, with the hint on its
own line: the parser kept an inline comment in the value, and a
placeholder would have failed every new backlog task.

promote-task says owner is the one field added by hand and gives a
handoff its shape; the pr skill and the active tasks' guide read owner.
Task 0144 records that blocked and archived tasks show their owner.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant