Preserve unsafe_load defaults with second-argument options - #1066
Closed
OskarEichler wants to merge 1 commit into
Closed
Preserve unsafe_load defaults with second-argument options#1066OskarEichler wants to merge 1 commit into
OskarEichler wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Normalize a Hash passed as
JSON.unsafe_load's second positional argument before applying options, then merge it over the unsafe defaults.Reproduction
The second-argument form added in #910 currently replaces the entire default set. External cases show it loses
create_additions,allow_blank, andallow_nan: Time additions remain raw hashes and blank/NaN input raises. The candidate preserves all three unless explicitly overridden.Verification
Compatibility
Only positional-options normalization changes, to match
unsafe_loaddefaults and the existing three-argument form. JSON 3's keyword API is unaffected. Prepared with AI-assisted source review; no repository tests or changelog were changed.