Repository navigation
Update Bootstrap to 5.3.8 - #257
Merged
Merged
Conversation
Bootstrap 5.2 dropped `unicode-bidi: bidi-override` from `pre` and `code`, which laid out RTL text in lesson code examples in logical order. Under 5.3 the language menu toggle, a plain `.btn` that is also a `.nav-link`, took the navbar's font and lost its border and focus ring states, so it now sets them itself. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Bootstrap 5.3 no longer sets `unicode-bidi` on `pre`, so the reset added in fa33ee6 has nothing left to undo. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code examples in the lesson body show RTL text in logical order, because Bootstrap 5.1.3 sets
unicode-bidi: bidi-overrideonpreandcode. #254 worked around it for the editors only. Bootstrap 5.2 dropped that rule, so I update Bootstrap to 5.3.8 and Popper to 2.11.8, and remove the editor workaround.Under 5.3 the language menu toggle, a
.btnwithout a variant that is also a.nav-link, shrank to the navbar's font and lost its border and focus ring on hover, press and open. The stylesheet now sets those for it.The rest of the 5.3 restyle stays as Bootstrap ships it. Corners on the toggle, dropdown, selects and hamburger go from 4px to 6px, and content links keep their red on hover instead of turning blue.
Generated with Claude Code