Repository navigation
Handle files opened by creat() like those opened by open() - #4140
Merged
Merged
Conversation
When the creat syscall reached rr (e.g. with -n), rr didn't refuse blacklisted files or install the file monitors that open() gets, so e.g. writes through the new fd to /proc/<pid>/mem weren't replayed. rr now also lets other tasks run while creat blocks, as for open. Test: proc_mem, blacklist Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[AI discovery through code reading - probably diesn't matter that much in practice, but still should be fixed - patch/test by AI]
When the creat syscall reached rr (e.g. with -n), rr didn't refuse blacklisted files or install the file monitors that open() gets, so e.g. writes through the new fd to /proc//mem weren't replayed. rr now also lets other tasks run while creat blocks, as for open.
Test: proc_mem, blacklist