refactor(frontend): drop registration flow, now owned by SiteNova

[andrii-shortio-dev]

Summary

Sign-up has moved to SiteNova, so the RocketAdmin frontend no longer needs to host it. This removes the registration page, its route, and every entry point that led there — 784 lines deleted across 13 files.

Removed

• components/registration/ and routes/registration.routes.ts — /registration now falls through to PageNotFoundComponent
• The demo navbar "Create account" CTA, and the whole !currentUser header actions block (its only other child was a self-referential "Login" link shown on /login)
• logoutAndRedirectToRegistration() from AppComponent
• signUpUser() / signUpWithGoogle() / signUpWithGithub() from AuthService, plus their specs, plus the now-unused NewAuthUser model

Follow-on cleanup the deletions exposed: the orphaned environment import in auth.service.ts (its only use was the fbq Signup pixel), the .actions .action CSS rules with no matching template nodes, and a stale doc comment on noAuthGuard.

Kept deliberately

• RegistrationProvider / externalRegistrationProvider — that's an existing user's auth provider, rendered in user-settings and company, not the sign-up flow
• Shared TurnstileComponent, UserPasswordComponent, EmailValidationDirective, provideZxvbnServiceForPSM — still used by invite-member, setup, login and password-reset
• Login, setup, email verification, password reset and company-member invitation are untouched

Heads-up for the backend

POST /saas/user/register, /saas/user/google/register and /saas/user/github/registration/request now have no caller in this app. The AW-419937947 Google Ads conversion tag and the Reg: * PostHog/angulartics events are also gone from here — if SiteNova doesn't fire equivalents, that funnel goes dark.

Test plan

• yarn build — succeeds; the only warnings are two pre-existing ones unrelated to this change (BreadcrumbsComponent unused in DbTableRowEditComponent, mat-icon projection in EditDatabaseSchemaComponent)
• yarn test:ci — 267 files / 1615 tests pass

🤖 Generated with Claude Code

Summary by CodeRabbit

• Removed Features
  • Removed account registration pages, forms, and signup options from the application.
  • Removed email, Google, and GitHub signup flows, including related verification controls.
  • Removed registration navigation and account-creation actions from the toolbar.
• Authentication
  • Existing login, two-factor authentication, email verification, and logout functionality remain available.
• Cleanup
  • Removed registration-related validation, styling, models, and automated tests.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 6dab5e7d-c0eb-48e0-9a5d-f1722c6fb96e

📥 Commits

Reviewing files that changed from the base of the PR and between c3a3ed8 and b1c2d7d.

📒 Files selected for processing (13)

• frontend/src/app/app-routing.module.ts
• frontend/src/app/app.component.css
• frontend/src/app/app.component.html
• frontend/src/app/app.component.ts
• frontend/src/app/components/registration/registration.component.css
• frontend/src/app/components/registration/registration.component.html
• frontend/src/app/components/registration/registration.component.spec.ts
• frontend/src/app/components/registration/registration.component.ts
• frontend/src/app/guards/no-auth.guard.ts
• frontend/src/app/models/user.ts
• frontend/src/app/routes/registration.routes.ts
• frontend/src/app/services/auth.service.spec.ts
• frontend/src/app/services/auth.service.ts

💤 Files with no reviewable changes (11)

• frontend/src/app/components/registration/registration.component.spec.ts
• frontend/src/app/services/auth.service.spec.ts
• frontend/src/app/routes/registration.routes.ts
• frontend/src/app/models/user.ts
• frontend/src/app/app.component.html
• frontend/src/app/app.component.css
• frontend/src/app/app-routing.module.ts
• frontend/src/app/components/registration/registration.component.html
• frontend/src/app/components/registration/registration.component.css
• frontend/src/app/app.component.ts
• frontend/src/app/components/registration/registration.component.ts

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.

---

📝 Walkthrough

Walkthrough

The frontend removes the registration route, component, navigation actions, signup service methods, signup tests, and NewAuthUser interface. Login and other existing authentication flows remain.

Changes

Registration removal

Layer / File(s)	Summary
Remove registration navigation frontend/src/app/app-routing.module.ts, frontend/src/app/app.component.*, frontend/src/app/guards/no-auth.guard.ts	Registration routing, navigation actions, the registration redirect method, and related styling are removed.
Remove registration implementation and signup contracts frontend/src/app/components/registration/*, frontend/src/app/routes/registration.routes.ts, frontend/src/app/services/auth.service.*, frontend/src/app/models/user.ts	The registration component, route configuration, signup methods and tests, and NewAuthUser interface are removed.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to b1c2d

This change removes the retired registration flow and its frontend entry points while keeping the remaining authentication flows intact; no actionable merge-blocking risk remains after normal checks and review.

Suggested reviewers: gugu

Poem

A rabbit hops where signup stood
The login path remains quite good
Routes fold up and buttons flee
Auth keeps its old continuity
Carrots celebrate clean code here

🚥 Pre-merge checks | ✅ 6

✅ Passed checks (6 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely summarizes the main change: removal of the frontend registration flow because SiteNova now owns registration.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Security Check	✅ Passed	PASS — The patch removes the RocketAdmin sign-up UI and its client callers. It introduces no new executable or security-sensitive behavior; the only additions are an updated comment and a retained `Ex…

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2 files.

Full details: Security Check

Explanation

PASS — The patch removes the RocketAdmin sign-up UI and its client callers. It introduces no new executable or security-sensitive behavior; the only additions are an updated comment and a retained ExistingAuthUser import. The /registration route is removed and now resolves to the existing static PageNotFoundComponent. Protected application routes still use AuthGuard, and the /login route still uses noAuthGuard. Login, 2FA, Google login, GitHub login, logout, email verification, password reset, invitation, Turnstile, and password-strength controls remain. The remaining SaaS registration endpoint is unchanged and is protected by the existing SaaSAuthMiddleware, which requires a valid microservice JWT and request_id. The exact diff contains only deletions plus documentation/import cleanup, and git diff --check is clean. No OWASP-relevant security reduction is attributable to this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch frontend_drop_registration

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}