Conversation
Adds a helper `Client.JobWaitFinalized` that polls waiting for a job to be finalized (completed, discarded, or cancelled) and returns it. The existing subscription functionality isn't appropriate for this because it only returns changes that occur within the existing client, so a job worked elsewhere wouldn't be returned. Implementation details: * Multiple calls to `JobWaitFinalized` share a single poll loop. * Polls every 250 ms. * A database and/or client change could add a notify signal that sends when a job is finalized, but that'd involve a more elaborate change, and would have downsides in that we'd have to be doing a lot of signaling even in case where no one's listening.
brandur
force-pushed
the
brandur-job-wait-finalized
branch
from
September 26, 2026 03:13
ba5e6b3 to
8caf757
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a helper
Client.JobWaitFinalizedthat polls waiting for a job tobe finalized (completed, discarded, or cancelled) and returns it.
The existing subscription functionality isn't appropriate for this
because it only returns changes that occur within the existing client,
so a job worked elsewhere wouldn't be returned.
Implementation details:
Multiple calls to
JobWaitFinalizedshare a single poll loop.Polls every 250 ms.
A database and/or client change could add a notify signal that sends
when a job is finalized, but that'd involve a more elaborate change,
and would have downsides in that we'd have to be doing a lot of
signaling even in case where no one's listening.