Use bundled PostgreSQL for CLI CI - #1392
Merged
Merged
Conversation
bgentry
force-pushed
the
bg/windows-ci-postgres
branch
2 times, most recently
from
September 26, 2026 00:34
e31b348 to
f3a59ee
Compare
bgentry
enabled auto-merge (squash)
September 26, 2026 00:56
Contributor
|
Shouldn't this remove the Chocolatey install somewhere too? |
bgentry
force-pushed
the
bg/windows-ci-postgres
branch
from
September 26, 2026 13:43
f3a59ee to
87254c2
Compare
The CLI job installs PostgreSQL through a setup action on both platforms, and its Windows Chocolatey download can fail before any CLI commands run when the package feed is unavailable. Start the PostgreSQL service already present on Ubuntu and set its credentials and database. On Windows, initialize a fresh cluster from the runner's bundled binaries and expose its client tools to later steps. Both paths use the runner's PostgreSQL without a package download. The separate database test matrix retains version coverage.
bgentry
force-pushed
the
bg/windows-ci-postgres
branch
from
September 26, 2026 13:43
87254c2 to
72f32da
Compare
Contributor
Author
|
@brandur it was the setup-postgres action that was using chocolatey under the hood to install a specific Postgres version. However, after interrogating Codex about this I realized that Postgres 17 is included on all GHA latest images. IMO that is good enough for the purposes of the CLI tests and we don’t need to worry about testing an exact latest PG version. I switched to that approach here which should make the runs faster and more reliable. |
bgentry
changed the title
Contributor
|
Ah gotcha. Okay. |
brandur
approved these changes
Sep 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows CLI CI installs PostgreSQL through Chocolatey on every run. A Chocolatey HTTP 503 failed the job on #1387 before any CLI commands ran.
Both hosted runner images already include PostgreSQL. Start Ubuntu's bundled service and create
river_devwith the existing credentials. On Windows, initialize a fresh cluster from the binaries exposed byPGBIN, wait for startup, and add the bundled client tools toPATH. This removes the external PostgreSQL setup action and its package downloads from the CLI job.The CLI job follows each runner image's PostgreSQL version. The separate Linux test matrix covers PostgreSQL 14–18.