Repository navigation
Follow one naming convention for all devices (breaking, 0.5.0) - #27
Merged
Merged
Conversation
name is Apple's official product name without the bracketed part, and extra lists what's left in a fixed order: generation or chip, size, connectivity, variant. - Apple Watch series, SE and Ultra move into the name - Generations and chips move from name to extra (iPad mini 5-7, iPad Air 3-4, 7th-gen iPad, A16 iPad) - Cellular iPads say Wi-Fi+Cellular instead of Wi-Fi+LTE or 3G - Fill in missing connectivity and GSM/CDMA/China variants, 1st gen for the first 11" and 12.9" iPad Pros, and 1TB models - Fix Mini/Gen capitalisation New specs keep generations out of names and enforce the extra vocabulary and order. The convention is documented in the README. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change, for 0.5.0. Moves every device to one naming convention based on Apple's official product names, and adds specs that enforce it.
Convention
nameis Apple's official name without the bracketed part: "iPad mini (6th generation)" →iPad mini; "Apple Watch Series 5" staysApple Watch Series 5. Numbers that are part of the name stay (iPad mini 4,iPad Air 2,Apple Watch SE 3).extrais a comma-separated list, in order: generation or chip (6th gen,M4,A17 Pro), size (44mm), connectivity (Wi-Fi,Wi-Fi+Cellular,GPS,GPS+Cellular), variant (GSM,CDMA,China,Rev A,1TB).This is documented in a new "Naming" section of the README.
What changes (133 of 239 entries)
name(Apple Watch Series 5/44mm, GPS+Cellular). Callers grouping byname == 'Apple Watch'need updating.extra: iPad mini 5/6/7, iPad Air 3/4, the 7th-gen iPad (wasiPad 10.2"), and the A16 iPad.Wi-Fi+Cellularinstead ofWi-Fi+LTE(wrong for 5G models) or3G.GSM/CDMAfor early cellular iPads and iPad minis,ChinaforiPad4,3,iPad4,6andiPad4,9(which saidRevor nothing),1st genfor the first 11" and 12.9" iPad Pros, and1TBfor the 1TB iPad Pros.miniinstead ofMini,geninstead ofGen,Rev A.Full old → new table
How this was done
spec/device_types_spec.rb: no generations orMiniin names, and everyextrapart comes from the vocabulary above, in order. I broke entries on purpose to confirm both specs fail.VERSIONisn't bumped here; it should be 0.5.0 at release.🤖 Generated with Claude Code