docs(readme): give each H2 heading a single authoritative section - #72
Conversation
Two H2 headings each appeared twice, so a reader hitting the second copy could not tell which one was current. Configuration: both copies described Anchor.toml and version environment variables, so they were merged into the first. The second copy documented `SOLANA_CLI_VERSION`, a variable that appears nowhere in the repo — the override actually honoured by scripts/setup.sh and the Dockerfile is `SOLANA_VERSION`, which the kept section already documents. Its one detail not already covered, the Anchor.toml `[scripts]` entrypoint, is carried over as a bullet. Development: the two copies covered different things. The first is implementation guidance (error handling, CPI, AI tooling, threat model); the second is how to validate the repo (scripts/test.sh, integration targets), so it is renamed to "Testing and Validation". No content moved. The README has no table of contents or in-page anchor links, so no link needed updating.
|
Understand this PR’s impact Explore downstream dependencies and potential security impact with Blast Radius. Important Review skippedReview was skipped as selected files did not have any reviewable changes. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe README now documents the ChangesREADME documentation
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Other 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🧪 Generate unit tests (beta)
🛠️ Fix failing CI checks 💡
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The audit of the changes in this pull request has been completed. Summary:
The audit passed with no issues found. Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "localhost"See Network Configuration for more information.
|
|
The audit of the changes in this pull request has been completed. Summary:
The audit passed with no issues found. Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "localhost"See Network Configuration for more information.
|
## Configurationand## Developmenteach appeared twice in the README. A reader landing on the second copy cannot tell which one is authoritative — that is the defect this fixes. Caught by the new README checks in the orgrepo-standardsworkflow (warn-only today).Configuration — merged
Both copies described the same thing:
Anchor.tomlplus version environment variables. The second was the coarser restatement and was also wrong: it documentedSOLANA_CLI_VERSION, which appears nowhere in this repo (and admitted as much — "Not directly used"). The override actually honoured isSOLANA_VERSION, read byscripts/setup.shand set as aDockerfileARG, and the kept section already documents it.Dropped from the second copy:
SOLANA_CLI_VERSIONbullet (variable does not exist here)**Anchor.toml**: Specifies program IDs for different clusters ... default provider settings (cluster URL, wallet)— already covered in more detail by the kept[programs.localnet]/[programs.devnet]and[provider]bulletsANCHOR_VERSIONbullet — already in the kept sectionCarried over: its one detail not covered anywhere else, the
Anchor.toml[scripts]entrypoint, added as a bullet (test = "bash ./scripts/test.sh").Development — renamed
These two genuinely cover different subjects, so nothing was merged. The first is implementation guidance (error handling, CPI, the
.claudeworkflow, threat model); the second is how to validate the repo (scripts/test.sh, the crate-local integration targets). The second is renamed to## Testing and Validation. No content moved or reworded.Verification
Ran the README block of the org
repo-standardschecker against this clone:README.md has duplicate H2 headings: ## Configuration ## DevelopmentThe README has no table of contents and no in-page anchor links (
](#), so the rename breaks no link.Summary by CodeRabbit
[scripts]anchor testentry point.