Repository navigation
docs: say what a Reply before the LinkedIn scheduler does with --schedule-id - #35
Merged
Merged
Conversation
…dule-id A Reply that has direct sends but not yet the LinkedIn scheduler answers scheduleId or useContactTimeZone on a LinkedIn send with a 400 whose errors[] names the field, which the CLI reports as reply.invalid_request; one that has neither sends at once. The LinkedIn sends' help and the README now say both.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The help of the four LinkedIn sends (
contact linkedin-connect,linkedin-message,linkedin-inmail,linkedin-voice) and the README's direct-send flags paragraph now say what a Reply without the LinkedIn scheduler does with the schedule's flags:The test comment that described the older behaviour is corrected to match. No code path changes.
Why
Reply's API can reach direct sends before it reaches the LinkedIn scheduler. Such a Reply refuses
scheduleIdoruseContactTimeZoneon a LinkedIn send with a 400 whoseerrors[]names the field, which the CLI already reports asreply.invalid_request. The help and README described only a Reply that knows neither feature: it ignores the fields and sends at once. A caller who meets the 400 should find it explained where they look, and know that the send was not made.Verification
commands.test.tsasserts the sentence in the help of each LinkedIn send and its absence fromcontact send-email's help. The assertion was seen failing before the help text changed.npm run build(tsc): clean.npm test(vitest): 60 files, 942 passed, 5 skipped, 0 failed.Release
A
docs:commit, so semantic-release publishes no release.