fix: enforce log message trailing period rule - #45265
Conversation
viceice
left a comment
There was a problem hiding this comment.
- failing tests
- tell AI to follow and fill PR template correctly
i checked again |
viceice
left a comment
There was a problem hiding this comment.
PR description still doesn't follow PR template.
- headlines missing
- check boxes missing
|
Hi there, |
I have now corrected it |
There was a problem hiding this comment.
Not sure if all this whitespace is intentional?
There was a problem hiding this comment.
this space was already there
| } else { | ||
| logger.debug( | ||
| { error }, | ||
| { err: error }, |
There was a problem hiding this comment.
no it is not intentional
jamietanna
left a comment
There was a problem hiding this comment.
Conflicted + comments
|
|
||
| const obj = callee.object; | ||
|
|
There was a problem hiding this comment.
these lines were already there no new lines added from my side
#44632
Add a custom
logger-static-messageOxlint rule to enforce Renovate logging conventions.warn,error, andfatallog messages to use static strings.errkey instead oferror.lib/.Context
This closes an existing Issue
Closes: #44632 — lint: don't allow trailing
.in log messagesThis doesn't close an Issue, but I accept the risk that this PR may be closed if maintainers disagree with its opening or implementation.
AI assistance disclosure
Did you use AI tools to create any part of this pull request?
AI was used to develop and refine the custom Oxlint
logger-static-messagerule, review the implementation, and help identify and fix existing logger violations across the codebase.Model used: GPT-5.6 Luna.
Use of AI in replying to PR comments
Documentation
How I've tested my work
I have verified these changes using:
Test results
The custom logger lint rule was verified across the repository with:
The changes also include fixes for existing logger violations throughout
lib/, covering:errmetadata usage for error objectswarn,error, andfatallogger calls