fix(limits): correct the published rate limit and file size, check descriptions - #79
Merged
Merged
Conversation
…scriptions The limits page advertised "30 vs 300/min" and "100 MB vs 2 GB" in its frontmatter description while its table, which is checked, said 120/600 and 500 MB/10 GB. The description understated the rate limit 4x and the file size 5x, and it is the text a search result and an AI answer quote. check-plan-limits.mjs only read tables. It now reads descriptions too, and each pattern must match: rephrase the sentence and it fails asking you to update the check, rather than quietly checking nothing. Two more checks were already dead and this surfaced them. "max batch size" matched no row because batches were removed from the product, and the storageQuota row was keyed on "total r2 storage" while the heading reads "Total object storage", so it had been silently unverified.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The limits page advertised "30 vs 300/min" and "100 MB vs 2 GB" in its
frontmatter description while its table, which is checked, said 120/600 and
500 MB/10 GB. The description understated the rate limit 4x and the file size
5x, and it is the text a search result and an AI answer quote.
check-plan-limits.mjs only read tables. It now reads descriptions too, and each
pattern must match: rephrase the sentence and it fails asking you to update the
check, rather than quietly checking nothing.
Two more checks were already dead and this surfaced them. "max batch size"
matched no row because batches were removed from the product, and the
storageQuota row was keyed on "total r2 storage" while the heading reads "Total
object storage", so it had been silently unverified.