Skip to content

fix(url-commands): reject out-of-range negative indices - #1064

Draft
JosephKav wants to merge 2 commits into
masterfrom
fix/service-urlcommand/indexing
Draft

JosephKav wants to merge 2 commits into
masterfrom
fix/service-urlcommand/indexing

Conversation

@JosephKav

Copy link
Copy Markdown
Collaborator
  • fixes uncaught panics on out-of-range negative indices.
  • don't skip versions after one expands
    • A split/regex that turned one version into several made later commands process the new pieces instead of the remaining versions, e.g. split " " then split "-" on "a-b c-d" errored instead of giving [a b c d].

A split/regex that turned one version into several made later commands
process the new pieces instead of the remaining versions
@JosephKav JosephKav added bug Something isn't working go Pull requests that update Go code labels Oct 27, 2026
@github-actions

Copy link
Copy Markdown

✅ Playwright Test Results

Count
✅ Passed 530
❌ Failed 0
🔄 Flaky 0
⏭️ Skipped 10

Duration: 1084.6s

View screenshots & full report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working go Pull requests that update Go code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant