chore(deps): Bump the docker-images group across 1 directory with 2 updates - #841
chore(deps): Bump the docker-images group across 1 directory with 2 updates#841dependabot[bot] wants to merge 1 commit into
Conversation
dependabot
Bot
added
dependencies
dependabot
Bot
added
dependencies
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6c17942f6b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| # syntax=docker/dockerfile:1.7@sha256:a57df69d0ea827fb7266491f2813635de6f17269be881f696fbfdf2d83dda33e | ||
|
|
||
| FROM rust:1.95-trixie@sha256:f49565f188ee00bc2a18dd418183f2c5f23ef7d6e691890517ed341a598f67c3 AS builder | ||
| FROM rust:1.98-trixie@sha256:620dbcd124499c59e2406d3741574b5c5838cf9eb9656f0c3a03948f79b02959 AS builder |
There was a problem hiding this comment.
Updating only this builder recipe leaves the repository's image contract inconsistent: .github/workflows/ci.yml runs release/scripts/check-debian13-images.py, whose RUST_BUILDER and DEBIAN_PREPARATION constants still require the old Rust and Debian digests. Running that gate on this commit reports this builder plus all five changed runtime Dockerfiles as failures, so the required CI cannot pass until the checker and the other maintained builder-pin surfaces are updated atomically with these Dockerfiles.
AGENTS.md reference: AGENTS.md:L192-L195
Useful? React with 👍 / 👎.
| ARG SOURCE_DATE_EPOCH=0 | ||
|
|
||
| FROM debian:trixie-slim@sha256:3a39a0592364683e6bab97937b72cad5a8fa6dcbbee90edb3bb48c7f8e94f258 AS runtime-root | ||
| FROM debian:trixie-slim@sha256:d7e12182ce18b85b93007c1dedf31f2d29e01ccf3182cc4017c709b6259bc132 AS runtime-root |
There was a problem hiding this comment.
Commit effe148f9622ced671ef49046641eac60ef6a1ae contains no Signed-off-by trailer (git interpret-trailers --parse returns none), so it violates the repository's mandatory DCO policy; recreate the commit with git commit -s before merging.
AGENTS.md reference: AGENTS.md:L312-L315
Useful? React with 👍 / 👎.
dependabot
Bot
changed the title
6c17942 to
a020bb9
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a020bb9167
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| ARG SOURCE_DATE_EPOCH=0 | ||
|
|
||
| FROM debian:trixie-slim@sha256:3a39a0592364683e6bab97937b72cad5a8fa6dcbbee90edb3bb48c7f8e94f258 AS runtime-root | ||
| FROM debian:trixie-slim@sha256:d7e12182ce18b85b93007c1dedf31f2d29e01ccf3182cc4017c709b6259bc132 AS runtime-root |
There was a problem hiding this comment.
Fresh evidence on the newly requested commit shows that f9526433050cc1c9c83b142a832030541d68fd13 also has no Signed-off-by trailer (git interpret-trailers --parse returns no trailers), so the earlier DCO issue was not resolved when the commit was recreated; sign off the replacement commit before merging.
AGENTS.md reference: AGENTS.md:L344-L346
Useful? React with 👍 / 👎.
| # syntax=docker/dockerfile:1.7@sha256:a57df69d0ea827fb7266491f2813635de6f17269be881f696fbfdf2d83dda33e | ||
|
|
||
| FROM rust:1.95-trixie@sha256:f49565f188ee00bc2a18dd418183f2c5f23ef7d6e691890517ed341a598f67c3 AS builder | ||
| FROM rust:1.98-trixie@sha256:620dbcd124499c59e2406d3741574b5c5838cf9eb9656f0c3a03948f79b02959 AS builder |
There was a problem hiding this comment.
On a clean canonical release build, build-release-binaries.sh runs this image with /workspace as its working directory, where rust-toolchain.toml still overrides Rust to 1.95.0 (rustup show active-toolchain confirms that selection). The rust:1.98-trixie image therefore does not make the build use Rust 1.98; instead rustup must download the absent 1.95 toolchain and requested components at container runtime, causing restricted/offline builds that previously worked with a populated Cargo cache to fail and moving the actual compiler outside the digest-pinned builder image. Keep the image on 1.95 or update the workspace toolchain as part of an intentional compiler upgrade.
Useful? React with 👍 / 👎.
a020bb9 to
a39c086
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a39c086203
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| ARG SOURCE_DATE_EPOCH=0 | ||
|
|
||
| FROM debian:trixie-slim@sha256:3a39a0592364683e6bab97937b72cad5a8fa6dcbbee90edb3bb48c7f8e94f258 AS runtime-root | ||
| FROM debian:trixie-slim@sha256:d7e12182ce18b85b93007c1dedf31f2d29e01ccf3182cc4017c709b6259bc132 AS runtime-root |
There was a problem hiding this comment.
Fresh evidence on the newly requested commit shows that a028604f978ac9c985aa410036625509cf6e321d still has no Signed-off-by trailer (git interpret-trailers --parse returns no trailers), so this replacement commit remains ineligible to merge under the repository's mandatory DCO policy; recreate it with git commit -s.
AGENTS.md reference: AGENTS.md:L370-L372
Useful? React with 👍 / 👎.
a39c086 to
f4db358
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f4db358536
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| ARG SOURCE_DATE_EPOCH=0 | ||
|
|
||
| FROM debian:trixie-slim@sha256:3a39a0592364683e6bab97937b72cad5a8fa6dcbbee90edb3bb48c7f8e94f258 AS runtime-root | ||
| FROM debian:trixie-slim@sha256:d7e12182ce18b85b93007c1dedf31f2d29e01ccf3182cc4017c709b6259bc132 AS runtime-root |
There was a problem hiding this comment.
Fresh evidence for the newly requested commit shows that e86f7321d4761eb9270b8bfcc3b770c72f91e9cd still has no Signed-off-by trailer (git interpret-trailers --parse returns no trailers), so the earlier DCO issue remains unresolved and this replacement commit is ineligible to merge until it is recreated with git commit -s.
AGENTS.md reference: AGENTS.md:L407-L407
Useful? React with 👍 / 👎.
…pdates Bumps the docker-images group with 2 updates in the /release/docker directory: debian and rust. Updates `debian` from `3a39a05` to `d7e1218` Updates `rust` from 1.95-trixie to 1.98-trixie --- updated-dependencies: - dependency-name: debian dependency-version: trixie-slim dependency-type: direct:production dependency-group: docker-images - dependency-name: rust dependency-version: 1.98-trixie dependency-type: direct:production dependency-group: docker-images ... Signed-off-by: dependabot[bot] <support@github.com>
f4db358 to
9978304
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 99783044d5
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| # syntax=docker/dockerfile:1.7@sha256:a57df69d0ea827fb7266491f2813635de6f17269be881f696fbfdf2d83dda33e | ||
|
|
||
| FROM rust:1.95-trixie@sha256:f49565f188ee00bc2a18dd418183f2c5f23ef7d6e691890517ed341a598f67c3 AS builder | ||
| FROM rust:1.98-trixie@sha256:bf5a9aa29062a6cb03c49bd59a46eb55e3cc770caf598a221a7866e500be3082 AS builder |
There was a problem hiding this comment.
Fresh evidence for 0633a2e is that python3 release/scripts/check-debian13-images.py fails against this exact commit: the checker, release workflows, and release build script still require the previous Rust and Debian digests, producing failures for the builder and all five runtime Dockerfiles. Update every maintained pin and its policy constants atomically, or revert these Dockerfile changes, so the required CI gate can pass.
AGENTS.md reference: AGENTS.md:L251-L254
Useful? React with 👍 / 👎.
| ARG SOURCE_DATE_EPOCH=0 | ||
|
|
||
| FROM debian:trixie-slim@sha256:3a39a0592364683e6bab97937b72cad5a8fa6dcbbee90edb3bb48c7f8e94f258 AS runtime-root | ||
| FROM debian:trixie-slim@sha256:d7e12182ce18b85b93007c1dedf31f2d29e01ccf3182cc4017c709b6259bc132 AS runtime-root |
There was a problem hiding this comment.
Fresh evidence for the newly requested commit shows that 0633a2edac7389e870c451c4136680b00bce1126 has no Signed-off-by trailer (git interpret-trailers --parse returns no trailers), so this replacement commit remains ineligible to merge under the repository's mandatory DCO policy; recreate it with git commit -s.
AGENTS.md reference: AGENTS.md:L405-L407
Useful? React with 👍 / 👎.
| # syntax=docker/dockerfile:1.7@sha256:a57df69d0ea827fb7266491f2813635de6f17269be881f696fbfdf2d83dda33e | ||
|
|
||
| FROM rust:1.95-trixie@sha256:f49565f188ee00bc2a18dd418183f2c5f23ef7d6e691890517ed341a598f67c3 AS builder | ||
| FROM rust:1.98-trixie@sha256:bf5a9aa29062a6cb03c49bd59a46eb55e3cc770caf598a221a7866e500be3082 AS builder |
There was a problem hiding this comment.
Fresh evidence on 0633a2e is that rust-toolchain.toml still selects Rust 1.95.0, while build-release-binaries.sh runs this image with the repository mounted as /workspace and that directory as the working directory. Rustup therefore ignores the bundled 1.98 compiler and downloads the absent 1.95 toolchain inside each ephemeral builder container; restricted/offline canonical builds fail, and the compiler actually used is no longer supplied by the digest-pinned image. Keep the builder on 1.95 or update the workspace toolchain as part of the upgrade.
Useful? React with 👍 / 👎.
Warning
Cooldown could not be applied because no publication date was available from the registry.
Bumps the docker-images group with 2 updates in the /release/docker directory: debian and rust.
Updates
debianfrom3a39a05tod7e1218Updates
rustfrom 1.95-trixie to 1.98-trixie