Repository navigation
feat(contact): enhance Contact Us section with modern hero, info cards, and accessible form (#1573) - #1814
Open
Tarulatapriya wants to merge 1 commit into
Open
feat(contact): enhance Contact Us section with modern hero, info cards, and accessible form (#1573)#1814Tarulatapriya wants to merge 1 commit into
Tarulatapriya wants to merge 1 commit into
Conversation
…s, and accessible form (reframe-oss#1573)
👷 Deploy request for reframe-os pending review.Visit the deploys page to approve it
|
Contributor
✅ PR Format Check Passed — @TarulatapriyaBasic format checks passed. A maintainer will review your code changes. This does not mean the PR is approved — it just means the format is correct. |
Contributor
👋 Thanks for your PR, @Tarulatapriya!Welcome to Reframe — a browser-based video editor built for everyone 🎬 What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
chiragjangiir
left a comment
There was a problem hiding this comment.
Technical Review of PR #1814: feat(contact): enhance Contact Us section with modern hero, info cards, and accessible form (#1573)
Great enhancement to Reframe's Contact experience, resolving #1573.
Strengths:
- Next.js App Router Architecture: Refactoring
src/app/contact/page.tsxinto a Server Component with exportedMetadata(title,description) while extracting interactive form logic intoContactClient.tsxis canonical Next.js 14+ practice. This preserves SEO metadata indexing while maintaining client-side interactivity. - Accessibility (a11y):
- Form inputs and textareas use proper
htmlForpairings, required badges, and explicitaria-invalidandaria-describedbyassociations pointing to error message containers (name-error,email-error,message-error). - Focus ring styling (
focus-visible:outline-2) ensures keyboard navigability complies with WCAG standards.
- Form inputs and textareas use proper
- User Experience & Feedback:
- Comprehensive validation regex for email, minimum character length for message bodies, and clear inline alert banners (
AlertCircle). - Loading indicator with
Loader2spinner and disabled state prevention against duplicate submissions. - Clean integration of brand color tokens (
var(--bg),var(--text),var(--accent),var(--border)).
- Comprehensive validation regex for email, minimum character length for message bodies, and clear inline alert banners (
Approved!
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Closes #1573.
Redesigned and enhanced the
/contactsection to align with Reframe's modern branding and visual polish while improving accessibility:aria-invalid,aria-describedby,role="status",role="alert"), explicit label associations, and static Next.js metadata export inpage.tsx.Verification
npx tsc --noEmit— 0 errors.npx eslint src/app/contact/— 0 errors.npx next build --webpack— Static export succeeded with 0 errors.