[CodeQuality] Skip DirectInstanceOverMockArgRector outside test classes - #776
Merged
Merged
Conversation
Gate the rule on TestsNodeAnalyzer::isInTestClass() before fetching scope. Non-test app code with a spread + named-arg new expression has no scope on the arg, so the eager ScopeFetcher::fetch() threw "Scope not available" and crashed the whole Rector run. The rule only handles Symfony Request mocks in tests anyway. Claude-Session: https://claude.ai/code/session_018faFsAZPx2pm78KBAwortK
TomasVotruba
enabled auto-merge (squash)
August 27, 2026 17:46
TomasVotruba
disabled auto-merge
August 27, 2026 17:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes crash reported in rectorphp/rector#9869.
Problem
DirectInstanceOverMockArgRectorcalledScopeFetcher::fetch($node)as its first action, before any guard. PHPStan does not assign scope to args of anewexpression that mixes an unpacked spread with a named argument, so the fetch threwScope not available— crashing the entire Rector run.Worse, this happened in non-test application code. The rule ships in the
phpunit-code-qualityset, so any project with this argument shape failed its whole run, even though the rule only ever touches SymfonyRequest/RequestStackmocks inside tests.Fix
Gate on
TestsNodeAnalyzer::isInTestClass()(resolves via reflection, no scope needed) and drop the eagerScopeFetcher::fetch()entirely. Non-test classes bail out early, before any scope is touched.Added a skip fixture reproducing the crashing shape in a non-test class.