Repository navigation
chore(l10n): fill the String Catalog and localize the Info.plist - #5
Closed
devaryakjha wants to merge 2 commits into
Closed
devaryakjha wants to merge 2 commits into
devaryakjha wants to merge 2 commits into
Conversation
Localizable.xcstrings was empty, so nothing in the app could be translated and there was no record of its strings. It now lists every key the code uses, with translator comments on the ones that are ambiguous on their own, and InfoPlist.xcstrings covers the local network usage description. Xcode keeps both up to date from here. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XfwUCp8GqHWUdTK7EhZCT5
…endabot' into claude/project-thread-eheuhr-strings
devaryakjha
changed the base branch from
main
to
claude/project-thread-eheuhr-dependabot
October 21, 2026 04:51
devaryakjha
added a commit
that referenced
this pull request
Oct 21, 2026
#3) Lands three pull requests in one: - #4 Pin Chek Reader to its 0.1.0 release instead of main, so any reader push can't break the app's next build and an App Store build is reproducible. Package.resolved records the tag's commit. - #5 chore(l10n): fill the String Catalog and localize the Info.plist. - #3 Weekly Dependabot updates for the actions CI uses. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XfwUCp8GqHWUdTK7EhZCT5
Contributor
Author
|
Landed on Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Arya · project thread
Before
The app's code already goes through SwiftUI's localized initializers and
String(localized:)everywhere, but the committedLocalizable.xcstringswas empty, so nothing could be translated and the repository had no record of the app's strings. The local network usage description inInfo.plisthad no catalog at all.After
Localizable.xcstringslists every key the code uses (281), with translator comments on the keys that are ambiguous on their own, such as "Read", "New", "Pages", "Original" and the search prompt.InfoPlist.xcstringscoversNSLocalNetworkUsageDescription. Translators have something to work from, and a key that goes missing now shows up as stale in Xcode instead of silently disappearing.How
The keys were extracted from the SwiftUI and Foundation calls in
apple/Chekand written in the catalog's JSON form, with interpolations as%@or%lldby the interpolated value's type. The project uses synchronized folders, soInfoPlist.xcstringsis picked up without a project change. No code changes.I couldn't run Xcode here. On the next build Xcode reconciles the catalog with what the compiler extracts; if it types an interpolated key differently from my reading, it will add the right key and mark mine stale, which is a one-click clean-up in the catalog editor.
Generated by Claude Code