Repository navigation
Clear the set-member signature cache per pathway (deltasignal specs/065) - #115
Merged
Merged
Conversation
prime_entity_caches cleared every per-pathway entity cache except variant_emission._sig_cache, so in a multi-pathway build a member's signature could come from an earlier pathway's prefetch-limited caches and the network depended on build order. Week review finding 12. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
adamjohnwright
marked this pull request as ready for review
October 16, 2026 14:22
Contributor
Author
|
Measured in deltasignal specs/065: all 92 networks identical in content, no predicted class changes. Ready to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
prime_entity_caches cleared every per-pathway entity cache except
variant_emission._sig_cache, so in a catalog build (one process, 92 pathways) a set member's signature could be the one computed from an earlier pathway's prefetch-limited caches: the network depended on build order. Week review finding 12._sig_cacheinprime_entity_caches.test_priming_a_pathway_clears_set_member_signatures(fails without the fix).🤖 Generated with Claude Code