Repository navigation
Port /data/discover/{identifier} to content-node - #519
Merged
Merged
Conversation
An event as a schema.org Dataset: DiscoverController over graph-core's SchemaDataSet, field by field (schemaDataSet). The event is loaded with graph-core's own findByStId query -- every relationship, both ways, unsorted -- and mapped by mapResult, because that load decides the order of creators and citations: r.order, relationship ids and one-type expands each disagree with Java on some event. Each edit's authors and each author's affiliations come as graph-core's LazyFetchAspect loads them (lazyCollectionQuery), repeated by stoichiometry. Not found is Java's 404, a non-event its 422 with a null message. Byte-identical to Java over 30 requests. Routed in nginx and the dev proxy. Spec 006 T082. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
An object with no relationship is null to graph-core's findByStId, so Java answers 404 whatever its class; node checked the class first and answered 422 for an orphaned non-event. The class is now checked after the load. Jackson's NON_EMPTY drops "" as well as null and [], so an empty description or name is left out. The handler's 200 path, its 404 after the load and a null stoichiometry are tested; no `differs`, since the Dataset's own url is content. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec 006 T082.
This endpoint describes an event as a schema.org Dataset, for search engines. It is
DiscoverControllerover graph-core'sSchemaDataSet, reproduced field by field (schemaDataSet).Ordering: graph-core's
findByIdhere isDatabaseObjectRepository.findByStId/findByDbId: every relationship, both ways, unsorted. Node runs that load and maps it withmapResult, as Spring Data maps it. That load decides the order of creators and citations. Sorting byr.order, by relationship id, or by a one-type expand each disagreed with Java on some event.Lazy loads: each edit's authors, and each author's affiliations, are loaded as graph-core's
LazyFetchAspectloads them: its query (lazyCollectionQuery), in relationship order, repeated by stoichiometry.Java's answers kept:
Parity: 50 requests against Java across two runs, all byte-identical (an error body's
urlaside). They cover pathways and reactions, URL, Book and multi-summation citations, an edit with no author, every id form, orphaned objects, and the 404, 422 and 500. No names were printed while checking; comparisons were by bytes and hashes.Review: an adversarial review found:
Routing: nginx and the dev proxy; the routing tests were shown failing first.
🤖 Generated with Claude Code