Repository navigation
content-node: read ids through graphCoreId in four more handlers - #518
Merged
Merged
Conversation
/participants/{id}, /participants/{id}/referenceEntities,
/detail/{id}/locationsInPWB and /instance/{id}/referrers each carried
their own copy of graph-core's id reading, REACT_ lookup included; they
now share graphCoreId. No change in behaviour: byte-identical to Java
over 20 requests across the four, with stable, dbId, REACT_ (found and
not) and unreadable ids. diagramResult and orthologyOf read ids through
inDepthId, a different rule, and keep their own lookup.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Belongs to spec 006 (no task of its own; it tidies the endpoints T019–T026 ported).
Four handlers each carried their own copy of graph-core's id reading, REACT_ lookup included:
/participants/{id}/participants/{id}/referenceEntities/detail/{id}/locationsInPWB/instance/{id}/referrersThey now share
graphCoreId, which #514 introduced.diagramResultandorthologyOfread ids throughinDepthId, a different rule, and keep their own lookup.No change in behaviour: byte-identical to Java over 20 requests across the four handlers, with stable, dbId, REACT_ (found and not) and unreadable ids.
Review: an adversarial review compared each removed block with
graphCoreIdand found them word for word the same. It checked what each handler returns for an id it can't read, the{id}params shape,byDbId, and that no use of the removedwhereis left. The one comment lost with the old blocks (findNewStId) is now ingraphCoreId's doc comment.🤖 Generated with Claude Code