Repository navigation
Port /data/participants/{id}/participatingPhysicalEntities to content-node - #517
Merged
Merged
Conversation
…-node graph-core's PhysicalEntityRepository query as written, every entity written by physicalEntityJson, the id read by graphCoreId, and Java's contract: [] for nothing found, a bare 200 for an id that is neither. Byte-identical to Java over 14 requests. Routed in nginx and the dev proxy beside /referenceEntities. Spec 006 T077. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec 006 T077.
This endpoint lists every physical entity taking part in an event, all the way down.
PhysicalEntityRepository.getParticipatingPhysicalEntities, kept as written.physicalEntityJson, which now covers every class (Port /data/complex/{id}/subunits and /data/complexes/{resource}/{identifier} #514).graphCoreId.[]. An id that is neither a stable id nor a dbId gets a 200 with no body.Parity: 14 requests against Java, all byte-identical. They cover every id form, REACT_ (found and not), unreadable ids and the 500, and a top-level pathway's 285 KB. The reviewer separately matched one reaction for each awkward entity class (Cell, Polymer, the three drugs, GenomeEncodedEntity, OtherEntity, CandidateSet), all byte-identical.
Review: an adversarial review found no defect. Its one surviving mutation (the id handed to the query) is now caught.
Routing: nginx and the dev proxy, beside
/referenceEntities; the routing tests were shown failing first.🤖 Generated with Claude Code