Skip to content

Style library: polymers drawn as polymers again (ngx-reactome-base #21) - #485

Merged
adamjohnwright merged 1 commit into
mainfrom
deps/style-library-polymers
Oct 16, 2026
Merged

adamjohnwright merged 1 commit into
mainfrom
deps/style-library-polymers

Conversation

@adamjohnwright

Copy link
Copy Markdown
Contributor

Moves ngx-reactome-cytoscape-style to the dist build of ngx-reactome-base's fb07239 (reactome/ngx-reactome-base#21). That PR holds the style-library fixes from the review of the changes since #373:

  • Polymers: protein, molecule and RNA polymers, and the legend's Polymer key, are drawn with their offset copy behind them again, instead of as a plain entity. This has been broken since Fix the diagram style library's caches, defaults and structure layers #373.
  • Crossed-out nodes: they now take the current theme's colour after a theme switch.
  • Minor fixes:
    • A node is redrawn after its size or analysis values change.
    • interpolate no longer misreads an exact 0.
    • The gradient cache is shared between nodes with equal values.

This changes one line of package-lock.json: the pinned build moves from 76de66a0 to f0e10f9f, the build of fb07239.

Checked in a browser from this branch: the legend's Polymer key is the stacked shape again, where beta's is still plain.

🤖 Generated with Claude Code

Moves ngx-reactome-cytoscape-style to the dist build of
ngx-reactome-base's fb07239 (#21), the fixes from the review of the
changes since #373:
- protein, molecule and RNA polymers -- and the legend's Polymer key --
  are drawn with their offset copy behind them again, not as a plain
  entity;
- crossed-out nodes take the theme's colour after a theme switch;
- a node redrawn after its size or values change; interpolate's exact 0;
  the gradient cache shared by equal values.

One line of the lockfile. Seen in a browser from this branch: the
legend's Polymer key is the stacked shape again, where beta's is plain.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@adamjohnwright
adamjohnwright merged commit 707b474 into main Oct 16, 2026
6 checks passed
@adamjohnwright
adamjohnwright deleted the deps/style-library-polymers branch October 16, 2026 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant