Repository navigation
Remove subgrid fallbacks (#127) - #768
Merged
Merged
Conversation
Contributor
|
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Update the stale public FormLayout README guidance and obsolete issue reference.
Review effort: Lite
Findings: 1
What changed in this PR
Removes obsolete CSS subgrid fallbacks while preserving display: contents for fieldset-based fields.
Changes:
- Removes fallback rules from form-field layouts.
- Updates subgrid and fieldset documentation.
- Retains fieldset-specific handling.
| File | Summary |
|---|---|
src/styles/tools/form-fields/_inline-field-layout.scss |
Removes inline-field fallbacks. |
src/styles/tools/form-fields/_inline-field-elements.scss |
Removes fallback tap-target styling. |
src/styles/tools/form-fields/_box-field-layout.scss |
Removes box-field fallback while preserving fieldset handling. |
src/components/FormLayout/FormLayout.module.scss |
Updates subgrid documentation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
adamkudrna
approved these changes
Oct 7, 2026
adamkudrna
left a comment
adamkudrna
left a comment
Member
There was a problem hiding this comment.
Please just remove the stale paragraph from the FormLayout README.
bedrich-schindler
force-pushed
the
refactoring/127
branch
from
October 20, 2026 13:12
e5221df to
047c3a1
Compare
bedrich-schindler
force-pushed
the
refactoring/127
branch
from
October 20, 2026 13:13
047c3a1 to
f968505
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All supported browsers support
subgrid, so the@supports not (grid-template-columns: subgrid)fallbacks in form field andFormLayoutstyles are removed. Form fields rendered as<fieldset>keepdisplay: contents, as subgrid does not work there yet (#232).Closes #127